diff options
| author | Simon Pilgrim <llvm-dev@redking.me.uk> | 2018-06-01 13:37:01 +0000 |
|---|---|---|
| committer | Simon Pilgrim <llvm-dev@redking.me.uk> | 2018-06-01 13:37:01 +0000 |
| commit | ee7694442d6ca7ed47bae8ffa3a766cbca68885b (patch) | |
| tree | 09ab6c7ec020e4f14441d15b57f2e4431dc1c676 /llvm/utils/UpdateTestChecks/asm.py | |
| parent | 8467411dada9e05130e5d8e5244d07749f4fa5e6 (diff) | |
| download | bcm5719-llvm-ee7694442d6ca7ed47bae8ffa3a766cbca68885b.tar.gz bcm5719-llvm-ee7694442d6ca7ed47bae8ffa3a766cbca68885b.zip | |
[Utils][X86] Help update_llc_test_checks.py to recognise retl/retq to reduce CHECK duplication (PR35003)
This patch replaces the --x86_extra_scrub command line argument to automatically support a second level of regex-scrubbing if it improves the matching of nearly-identical code patterns. The argument '--extra_scrub' is there now to force extra matching if required.
This is mostly useful to help us share 32-bit/64-bit x86 vector tests which only differs by retl/retq instructions, but any scrubber can now technically support this, meaning test checks don't have to be needlessly obfuscated.
I've updated some of the existing checks that had been manually run with --x86_extra_scrub, to demonstrate the extra "ret{{[l|q]}}" scrub now only happens when useful, and re-run the sse42-intrinsics file to show extra matches - most sse/avx intrinsics files should be able to now share 32/64 checks.
Tested with the opt/analysis scripts as well which share common code - AFAICT the other update scripts use their own versions.
Differential Revision: https://reviews.llvm.org/D47485
llvm-svn: 333749
Diffstat (limited to 'llvm/utils/UpdateTestChecks/asm.py')
| -rw-r--r-- | llvm/utils/UpdateTestChecks/asm.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/utils/UpdateTestChecks/asm.py b/llvm/utils/UpdateTestChecks/asm.py index f3feb3507ce..10b35b56f9d 100644 --- a/llvm/utils/UpdateTestChecks/asm.py +++ b/llvm/utils/UpdateTestChecks/asm.py @@ -107,7 +107,7 @@ def scrub_asm_x86(asm, args): asm = SCRUB_X86_RIP_RE.sub(r'{{.*}}(%rip)', asm) # Generically match a LCP symbol. asm = SCRUB_X86_LCP_RE.sub(r'{{\.LCPI.*}}', asm) - if getattr(args, 'x86_extra_scrub', False): + if getattr(args, 'extra_scrub', False): # Avoid generating different checks for 32- and 64-bit because of 'retl' vs 'retq'. asm = SCRUB_X86_RET_RE.sub(r'ret{{[l|q]}}', asm) # Strip kill operands inserted into the asm. |
