diff options
author | Rafael Espindola <rafael.espindola@gmail.com> | 2014-06-06 01:20:28 +0000 |
---|---|---|
committer | Rafael Espindola <rafael.espindola@gmail.com> | 2014-06-06 01:20:28 +0000 |
commit | 42a4c9f9e094419c27e53c4fbc4f2fd23887c7c5 (patch) | |
tree | 63f9a89579652de86471aef88e3f56f911476343 /llvm/unittests | |
parent | f251e0051c269ac5f60839f5cbce7675ea158ca0 (diff) | |
download | bcm5719-llvm-42a4c9f9e094419c27e53c4fbc4f2fd23887c7c5.tar.gz bcm5719-llvm-42a4c9f9e094419c27e53c4fbc4f2fd23887c7c5.zip |
Allow aliases to be unnamed_addr.
Alias with unnamed_addr were in a strange state. It is stored in GlobalValue,
the language reference talks about "unnamed_addr aliases" but the verifier
was rejecting them.
It seems natural to allow unnamed_addr in aliases:
* It is a property of how it is accessed, not of the data itself.
* It is perfectly possible to write code that depends on the address
of an alias.
This patch then makes unname_addr legal for aliases. One side effect is that
the syntax changes for a corner case: In globals, unnamed_addr is now printed
before the address space.
llvm-svn: 210302
Diffstat (limited to 'llvm/unittests')
-rw-r--r-- | llvm/unittests/IR/VerifierTest.cpp | 17 |
1 files changed, 0 insertions, 17 deletions
diff --git a/llvm/unittests/IR/VerifierTest.cpp b/llvm/unittests/IR/VerifierTest.cpp index 252bdd333c1..71e3168b686 100644 --- a/llvm/unittests/IR/VerifierTest.cpp +++ b/llvm/unittests/IR/VerifierTest.cpp @@ -44,23 +44,6 @@ TEST(VerifierTest, Branch_i1) { EXPECT_TRUE(verifyFunction(*F)); } -TEST(VerifierTest, AliasUnnamedAddr) { - LLVMContext &C = getGlobalContext(); - Module M("M", C); - Type *Ty = Type::getInt8Ty(C); - Constant *Init = Constant::getNullValue(Ty); - GlobalVariable *Aliasee = new GlobalVariable(M, Ty, true, - GlobalValue::ExternalLinkage, - Init, "foo"); - auto *GA = GlobalAlias::create(GlobalValue::ExternalLinkage, "bar", Aliasee); - GA->setUnnamedAddr(true); - std::string Error; - raw_string_ostream ErrorOS(Error); - EXPECT_TRUE(verifyModule(M, &ErrorOS)); - EXPECT_TRUE( - StringRef(ErrorOS.str()).startswith("Alias cannot have unnamed_addr")); -} - TEST(VerifierTest, InvalidRetAttribute) { LLVMContext &C = getGlobalContext(); Module M("M", C); |