summaryrefslogtreecommitdiffstats
path: root/llvm/unittests/tools
diff options
context:
space:
mode:
authorGuillaume Chatelet <gchatelet@google.com>2018-06-07 07:51:16 +0000
committerGuillaume Chatelet <gchatelet@google.com>2018-06-07 07:51:16 +0000
commit8c91d4cb04ab565d7c0d62c52a9f485a398830e8 (patch)
tree8d6954b4669a6ab95cc0f9efc92fe6ce5b422e88 /llvm/unittests/tools
parent30c5e4ad35101f88b50bab66bd57ffc66f8a7664 (diff)
downloadbcm5719-llvm-8c91d4cb04ab565d7c0d62c52a9f485a398830e8.tar.gz
bcm5719-llvm-8c91d4cb04ab565d7c0d62c52a9f485a398830e8.zip
[llvm-exegesis] Improve error reporting.
Summary: BenchmarkResult IO functions now return an Error or Expected so caller can deal take proper action. Reviewers: courbet Subscribers: tschuett, llvm-commits Differential Revision: https://reviews.llvm.org/D47868 llvm-svn: 334167
Diffstat (limited to 'llvm/unittests/tools')
-rw-r--r--llvm/unittests/tools/llvm-exegesis/BenchmarkResultTest.cpp8
1 files changed, 5 insertions, 3 deletions
diff --git a/llvm/unittests/tools/llvm-exegesis/BenchmarkResultTest.cpp b/llvm/unittests/tools/llvm-exegesis/BenchmarkResultTest.cpp
index 4428dcf0537..a35ea05cb60 100644
--- a/llvm/unittests/tools/llvm-exegesis/BenchmarkResultTest.cpp
+++ b/llvm/unittests/tools/llvm-exegesis/BenchmarkResultTest.cpp
@@ -55,6 +55,7 @@ static constexpr const unsigned kReg2Id = 2;
static constexpr const char kReg2Name[] = "Reg2";
TEST(BenchmarkResultTest, WriteToAndReadFromDisk) {
+ llvm::ExitOnError ExitOnErr;
BenchmarkResultContext Ctx;
Ctx.addInstrEntry(kInstrId, kInstrName);
Ctx.addRegEntry(kReg1Id, kReg1Name);
@@ -83,11 +84,12 @@ TEST(BenchmarkResultTest, WriteToAndReadFromDisk) {
EC = llvm::sys::fs::createUniqueDirectory("BenchmarkResultTestDir", Filename);
ASSERT_FALSE(EC);
llvm::sys::path::append(Filename, "data.yaml");
- ToDisk.writeYamlOrDie(Ctx, Filename);
+ ExitOnErr(ToDisk.writeYaml(Ctx, Filename));
{
// One-element version.
- const auto FromDisk = InstructionBenchmark::readYamlOrDie(Ctx, Filename);
+ const auto FromDisk =
+ ExitOnErr(InstructionBenchmark::readYaml(Ctx, Filename));
EXPECT_EQ(FromDisk.Key.OpcodeName, ToDisk.Key.OpcodeName);
EXPECT_THAT(FromDisk.Key.Instructions,
@@ -104,7 +106,7 @@ TEST(BenchmarkResultTest, WriteToAndReadFromDisk) {
{
// Vector version.
const auto FromDiskVector =
- InstructionBenchmark::readYamlsOrDie(Ctx, Filename);
+ ExitOnErr(InstructionBenchmark::readYamls(Ctx, Filename));
ASSERT_EQ(FromDiskVector.size(), size_t{1});
const auto FromDisk = FromDiskVector[0];
EXPECT_EQ(FromDisk.Key.OpcodeName, ToDisk.Key.OpcodeName);
OpenPOWER on IntegriCloud