diff options
| author | Pavel Labath <labath@google.com> | 2018-06-11 10:28:04 +0000 | 
|---|---|---|
| committer | Pavel Labath <labath@google.com> | 2018-06-11 10:28:04 +0000 | 
| commit | d8c6290ba46d2aafb0d9ff8f1ed361da588b44df (patch) | |
| tree | 14111d8461876324f651939fc276c5ef9a2f23f8 /llvm/unittests/Support | |
| parent | b896c4e86005657cca6ba96960779b36016a9189 (diff) | |
| download | bcm5719-llvm-d8c6290ba46d2aafb0d9ff8f1ed361da588b44df.tar.gz bcm5719-llvm-d8c6290ba46d2aafb0d9ff8f1ed361da588b44df.zip | |
Move VersionTuple from clang/Basic to llvm/Support
Summary:
This kind of functionality is useful to other project apart from clang.
LLDB works with version numbers a lot, but it does not have a convenient
abstraction for this. Moving this class to a lower level library allows
it to be freely used within LLDB.
Since this class is used in a lot of places in clang, and it used to be
in the clang namespace, it seemed appropriate to add it to the list of
adopted classes in LLVM.h to avoid prefixing all uses with "llvm::".
Also, I didn't find any tests specific for this class, so I wrote a
couple of quick ones for the more interesting bits of functionality.
Reviewers: zturner, erik.pilkington
Subscribers: mgorny, cfe-commits, llvm-commits
Differential Revision: https://reviews.llvm.org/D47887
llvm-svn: 334399
Diffstat (limited to 'llvm/unittests/Support')
| -rw-r--r-- | llvm/unittests/Support/CMakeLists.txt | 1 | ||||
| -rw-r--r-- | llvm/unittests/Support/VersionTupleTest.cpp | 50 | 
2 files changed, 51 insertions, 0 deletions
| diff --git a/llvm/unittests/Support/CMakeLists.txt b/llvm/unittests/Support/CMakeLists.txt index 89e16ef4b3f..4b46387a471 100644 --- a/llvm/unittests/Support/CMakeLists.txt +++ b/llvm/unittests/Support/CMakeLists.txt @@ -61,6 +61,7 @@ add_llvm_unittest(SupportTests    TrailingObjectsTest.cpp    TrigramIndexTest.cpp    UnicodeTest.cpp +  VersionTupleTest.cpp    YAMLIOTest.cpp    YAMLParserTest.cpp    formatted_raw_ostream_test.cpp diff --git a/llvm/unittests/Support/VersionTupleTest.cpp b/llvm/unittests/Support/VersionTupleTest.cpp new file mode 100644 index 00000000000..cd7ecda5fef --- /dev/null +++ b/llvm/unittests/Support/VersionTupleTest.cpp @@ -0,0 +1,50 @@ +//===- VersionTupleTests.cpp - Version Number Handling Tests --------------===// +// +//                     The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +#include "llvm/Support/VersionTuple.h" +#include "gtest/gtest.h" + +using namespace llvm; + +TEST(VersionTuple, getAsString) { +  EXPECT_EQ("0", VersionTuple().getAsString()); +  EXPECT_EQ("1", VersionTuple(1).getAsString()); +  EXPECT_EQ("1.2", VersionTuple(1, 2).getAsString()); +  EXPECT_EQ("1.2.3", VersionTuple(1, 2, 3).getAsString()); +  EXPECT_EQ("1.2.3.4", VersionTuple(1, 2, 3, 4).getAsString()); +} + +TEST(VersionTuple, tryParse) { +  VersionTuple VT; + +  EXPECT_FALSE(VT.tryParse("1")); +  EXPECT_EQ("1", VT.getAsString()); + +  EXPECT_FALSE(VT.tryParse("1.2")); +  EXPECT_EQ("1.2", VT.getAsString()); + +  EXPECT_FALSE(VT.tryParse("1.2.3")); +  EXPECT_EQ("1.2.3", VT.getAsString()); + +  EXPECT_FALSE(VT.tryParse("1.2.3.4")); +  EXPECT_EQ("1.2.3.4", VT.getAsString()); + +  EXPECT_TRUE(VT.tryParse("")); +  EXPECT_TRUE(VT.tryParse("1.")); +  EXPECT_TRUE(VT.tryParse("1.2.")); +  EXPECT_TRUE(VT.tryParse("1.2.3.")); +  EXPECT_TRUE(VT.tryParse("1.2.3.4.")); +  EXPECT_TRUE(VT.tryParse("1.2.3.4.5")); +  EXPECT_TRUE(VT.tryParse("1-2")); +  EXPECT_TRUE(VT.tryParse("1+2")); +  EXPECT_TRUE(VT.tryParse(".1")); +  EXPECT_TRUE(VT.tryParse(" 1")); +  EXPECT_TRUE(VT.tryParse("1 ")); +  EXPECT_TRUE(VT.tryParse(".")); +} | 

