diff options
author | Rafael Espindola <rafael.espindola@gmail.com> | 2015-06-13 17:23:04 +0000 |
---|---|---|
committer | Rafael Espindola <rafael.espindola@gmail.com> | 2015-06-13 17:23:04 +0000 |
commit | 74f293249d9e60e3631fc8b08148ef3d8a4df72d (patch) | |
tree | 8d85e53c7147f1a63ef6acee449d99283dedf5b9 /llvm/unittests/Support | |
parent | d3f64274462e500724ae2df9d7b590094eff87b4 (diff) | |
download | bcm5719-llvm-74f293249d9e60e3631fc8b08148ef3d8a4df72d.tar.gz bcm5719-llvm-74f293249d9e60e3631fc8b08148ef3d8a4df72d.zip |
Don't use std::errc.
As noted on Errc.h:
// * std::errc is just marked with is_error_condition_enum. This means that
// common patters like AnErrorCode == errc::no_such_file_or_directory take
// 4 virtual calls instead of two comparisons.
And on some libstdc++ those virtual functions conclude that
------------------------
int main() {
std::error_code foo = std::make_error_code(std::errc::no_such_file_or_directory);
return foo == std::errc::no_such_file_or_directory;
}
-------------------------
should exit with 0.
llvm-svn: 239683
Diffstat (limited to 'llvm/unittests/Support')
-rw-r--r-- | llvm/unittests/Support/ErrorOrTest.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/llvm/unittests/Support/ErrorOrTest.cpp b/llvm/unittests/Support/ErrorOrTest.cpp index 5e8d442a703..73d0e3f2bb7 100644 --- a/llvm/unittests/Support/ErrorOrTest.cpp +++ b/llvm/unittests/Support/ErrorOrTest.cpp @@ -67,8 +67,8 @@ TEST(ErrorOr, Covariant) { } TEST(ErrorOr, Comparison) { - ErrorOr<int> x(std::errc::no_such_file_or_directory); - EXPECT_EQ(x, std::errc::no_such_file_or_directory); + ErrorOr<int> x(errc::no_such_file_or_directory); + EXPECT_EQ(x, errc::no_such_file_or_directory); } // ErrorOr<int*> x(nullptr); |