diff options
| author | Reid Kleckner <rnk@google.com> | 2017-03-16 22:59:15 +0000 |
|---|---|---|
| committer | Reid Kleckner <rnk@google.com> | 2017-03-16 22:59:15 +0000 |
| commit | 45707d4d5a11292ac5b15704a494fa970cbc650e (patch) | |
| tree | cb70c405d50cfcf2d8304b4546a7992d06ba1808 /llvm/unittests/IR/ValueTest.cpp | |
| parent | c9a392b9dd7791420aa6475f8a2a81bf5731dfa6 (diff) | |
| download | bcm5719-llvm-45707d4d5a11292ac5b15704a494fa970cbc650e.tar.gz bcm5719-llvm-45707d4d5a11292ac5b15704a494fa970cbc650e.zip | |
Remove getArgumentList() in favor of arg_begin(), args(), etc
Users often call getArgumentList().size(), which is a linear way to get
the number of function arguments. arg_size(), on the other hand, is
constant time.
In general, the fact that arguments are stored in an iplist is an
implementation detail, so I've removed it from the Function interface
and moved all other users to the argument container APIs (arg_begin(),
arg_end(), args(), arg_size()).
Reviewed By: chandlerc
Differential Revision: https://reviews.llvm.org/D31052
llvm-svn: 298010
Diffstat (limited to 'llvm/unittests/IR/ValueTest.cpp')
| -rw-r--r-- | llvm/unittests/IR/ValueTest.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/unittests/IR/ValueTest.cpp b/llvm/unittests/IR/ValueTest.cpp index 607b7a1bd2c..142444a809c 100644 --- a/llvm/unittests/IR/ValueTest.cpp +++ b/llvm/unittests/IR/ValueTest.cpp @@ -40,7 +40,7 @@ TEST(ValueTest, UsedInBasicBlock) { Function *F = M->getFunction("f"); EXPECT_FALSE(F->isUsedInBasicBlock(&F->front())); - EXPECT_TRUE((++F->arg_begin())->isUsedInBasicBlock(&F->front())); + EXPECT_TRUE(std::next(F->arg_begin())->isUsedInBasicBlock(&F->front())); EXPECT_TRUE(F->arg_begin()->isUsedInBasicBlock(&F->front())); } |
