diff options
| author | Sanjay Patel <spatel@rotateright.com> | 2014-09-02 20:03:00 +0000 |
|---|---|---|
| committer | Sanjay Patel <spatel@rotateright.com> | 2014-09-02 20:03:00 +0000 |
| commit | b2325b9ab36584c43b762295aa36db0a62413c93 (patch) | |
| tree | bcc7b1864a315e09569727011cbeb1ee3acec70f /llvm/unittests/IR/IRBuilderTest.cpp | |
| parent | 0e893f53dd302f2af3550c058c2baef715204a30 (diff) | |
| download | bcm5719-llvm-b2325b9ab36584c43b762295aa36db0a62413c93.tar.gz bcm5719-llvm-b2325b9ab36584c43b762295aa36db0a62413c93.zip | |
Fix a logic bug when copying fast-math flags.
"Setting" does not equal "copying". This bug has sat dormant for 2 reasons:
1. The unit test was not adequate.
2. Every current user of the "copyFastMathFlags" API is operating on a new instruction.
(ie, all existing fast-math flags are off). If you copy flags to an existing
instruction that has some flags on already, you will not necessarily turn them off
as expected.
I uncovered this bug while trying to implement a fix for PR20802.
llvm-svn: 216939
Diffstat (limited to 'llvm/unittests/IR/IRBuilderTest.cpp')
| -rw-r--r-- | llvm/unittests/IR/IRBuilderTest.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/llvm/unittests/IR/IRBuilderTest.cpp b/llvm/unittests/IR/IRBuilderTest.cpp index 21085755fba..df5c8406477 100644 --- a/llvm/unittests/IR/IRBuilderTest.cpp +++ b/llvm/unittests/IR/IRBuilderTest.cpp @@ -189,12 +189,16 @@ TEST_F(IRBuilderTest, FastMathFlags) { Builder.clearFastMathFlags(); + // To test a copy, make sure that a '0' and a '1' change state. F = Builder.CreateFDiv(F, F); ASSERT_TRUE(isa<Instruction>(F)); FDiv = cast<Instruction>(F); EXPECT_FALSE(FDiv->getFastMathFlags().any()); + FDiv->setHasAllowReciprocal(true); + FAdd->setHasAllowReciprocal(false); FDiv->copyFastMathFlags(FAdd); EXPECT_TRUE(FDiv->hasNoNaNs()); + EXPECT_FALSE(FDiv->hasAllowReciprocal()); } |
