diff options
author | Bill Schmidt <wschmidt@linux.vnet.ibm.com> | 2013-07-26 21:39:15 +0000 |
---|---|---|
committer | Bill Schmidt <wschmidt@linux.vnet.ibm.com> | 2013-07-26 21:39:15 +0000 |
commit | 419f7c2345b7a2b553629e909ed29297bdeeb566 (patch) | |
tree | f75e575b82087b767f12abe5745ba762847bbe3d /llvm/unittests/ExecutionEngine/JIT/MultiJITTest.cpp | |
parent | 8c86ead149e154bd41901c78140d6c5e889bd739 (diff) | |
download | bcm5719-llvm-419f7c2345b7a2b553629e909ed29297bdeeb566.tar.gz bcm5719-llvm-419f7c2345b7a2b553629e909ed29297bdeeb566.zip |
[PowerPC] Improve consistency in use of __ppc__, __powerpc__, etc.
Both GCC and LLVM will implicitly define __ppc__ and __powerpc__ for
all PowerPC targets, whether 32- or 64-bit. They will both implicitly
define __ppc64__ and __powerpc64__ for 64-bit PowerPC targets, and not
for 32-bit targets. We cannot be sure that all other possible
compilers used to compile Clang/LLVM define both __ppc__ and
__powerpc__, for example, so it is best to check for both when relying
on either inside the Clang/LLVM code base.
This patch makes sure we always check for both variants. In addition,
it fixes one unnecessary check in lib/Target/PowerPC/PPCJITInfo.cpp.
(At least one of __ppc__ and __powerpc__ should always be defined when
compiling for a PowerPC target, no matter which compiler is used, so
testing for them is unnecessary.)
There are some places in the compiler that check for other variants,
like __POWERPC__ and _POWER, and I have left those in place. There is
no need to add them elsewhere. This seems to be in Apple-specific
code, and I won't take a chance on breaking it.
There is no intended change in behavior; thus, no test cases are
added.
llvm-svn: 187248
Diffstat (limited to 'llvm/unittests/ExecutionEngine/JIT/MultiJITTest.cpp')
-rw-r--r-- | llvm/unittests/ExecutionEngine/JIT/MultiJITTest.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/llvm/unittests/ExecutionEngine/JIT/MultiJITTest.cpp b/llvm/unittests/ExecutionEngine/JIT/MultiJITTest.cpp index 4018cd5ce2f..29689b71a24 100644 --- a/llvm/unittests/ExecutionEngine/JIT/MultiJITTest.cpp +++ b/llvm/unittests/ExecutionEngine/JIT/MultiJITTest.cpp @@ -21,7 +21,8 @@ using namespace llvm; namespace { // ARM, PowerPC and SystemZ tests disabled pending fix for PR10783. -#if !defined(__arm__) && !defined(__powerpc__) && !defined(__s390__) +#if !defined(__arm__) && !defined(__powerpc__) && !defined(__s390__) && \ + !defined(__ppc__) bool LoadAssemblyInto(Module *M, const char *assembly) { SMDiagnostic Error; |