diff options
| author | Chandler Carruth <chandlerc@gmail.com> | 2017-08-11 05:47:13 +0000 |
|---|---|---|
| committer | Chandler Carruth <chandlerc@gmail.com> | 2017-08-11 05:47:13 +0000 |
| commit | 19913b22c0996ecb039aa845217f19e00d88d8d8 (patch) | |
| tree | de3b66e5fda72095006cfb1b2778284249686d8c /llvm/unittests/Analysis | |
| parent | 9d07ae77e756111537e9e7bdcc0ed0cfbe42927e (diff) | |
| download | bcm5719-llvm-19913b22c0996ecb039aa845217f19e00d88d8d8.tar.gz bcm5719-llvm-19913b22c0996ecb039aa845217f19e00d88d8d8.zip | |
[PM] Switch the CGSCC debug messages to use the standard LLVM debug
printing techniques with a DEBUG_TYPE controlling them.
It was a mistake to start re-purposing the pass manager `DebugLogging`
variable for generic debug printing -- those logs are intended to be
very minimal and primarily used for testing. More detailed and
comprehensive logging doesn't make sense there (it would only make for
brittle tests).
Moreover, we kept forgetting to propagate the `DebugLogging` variable to
various places making it also ineffective and/or unavailable. Switching
to `DEBUG_TYPE` makes this a non-issue.
llvm-svn: 310695
Diffstat (limited to 'llvm/unittests/Analysis')
| -rw-r--r-- | llvm/unittests/Analysis/CGSCCPassManagerTest.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/llvm/unittests/Analysis/CGSCCPassManagerTest.cpp b/llvm/unittests/Analysis/CGSCCPassManagerTest.cpp index e2481826597..aa0be73fdf2 100644 --- a/llvm/unittests/Analysis/CGSCCPassManagerTest.cpp +++ b/llvm/unittests/Analysis/CGSCCPassManagerTest.cpp @@ -1168,8 +1168,8 @@ TEST_F(CGSCCPassManagerTest, TestAnalysisInvalidationCGSCCUpdate) { "dummy", &*H2F.begin()->begin()); // Now update the call graph. - auto &NewC = updateCGAndAnalysisManagerForFunctionPass( - CG, C, H2N, AM, UR, /*DebugLogging*/ true); + auto &NewC = + updateCGAndAnalysisManagerForFunctionPass(CG, C, H2N, AM, UR); assert(&NewC != &C && "Should get a new SCC due to update!"); (void)&NewC; @@ -1214,8 +1214,8 @@ TEST_F(CGSCCPassManagerTest, TestAnalysisInvalidationCGSCCUpdate) { (void)CallInst::Create(&H3F, {}, "", &*H2F.begin()->begin()); // Now update the call graph. - auto &NewC = updateCGAndAnalysisManagerForFunctionPass( - CG, C, H2N, AM, UR, /*DebugLogging*/ true); + auto &NewC = + updateCGAndAnalysisManagerForFunctionPass(CG, C, H2N, AM, UR); assert(&NewC != &C && "Should get a new SCC due to update!"); (void)&NewC; |

