summaryrefslogtreecommitdiffstats
path: root/llvm/tools
diff options
context:
space:
mode:
authorVedant Kumar <vsk@apple.com>2016-06-28 16:12:12 +0000
committerVedant Kumar <vsk@apple.com>2016-06-28 16:12:12 +0000
commitde717e655bc94be2d0e7dee0fed0e9d17a066ee5 (patch)
tree66105082468e0809dc4225153abfa1a80c6c207d /llvm/tools
parent1c7d532cde3117a21ade6c5501e6bcf87d7555eb (diff)
downloadbcm5719-llvm-de717e655bc94be2d0e7dee0fed0e9d17a066ee5.tar.gz
bcm5719-llvm-de717e655bc94be2d0e7dee0fed0e9d17a066ee5.zip
[llvm-cov] Move a check into a helper method (NFC)
llvm-svn: 274025
Diffstat (limited to 'llvm/tools')
-rw-r--r--llvm/tools/llvm-cov/CoverageViewOptions.h3
-rw-r--r--llvm/tools/llvm-cov/SourceCoverageView.cpp2
2 files changed, 4 insertions, 1 deletions
diff --git a/llvm/tools/llvm-cov/CoverageViewOptions.h b/llvm/tools/llvm-cov/CoverageViewOptions.h
index bde8b82520b..ff23a619fde 100644
--- a/llvm/tools/llvm-cov/CoverageViewOptions.h
+++ b/llvm/tools/llvm-cov/CoverageViewOptions.h
@@ -37,6 +37,9 @@ struct CoverageViewOptions {
raw_ostream::Colors Color) const {
return llvm::colored_ostream(OS, Color, Colors);
}
+
+ /// \brief Check if an output directory has been specified.
+ bool hasOutputDirectory() const { return ShowOutputDirectory != ""; }
};
}
diff --git a/llvm/tools/llvm-cov/SourceCoverageView.cpp b/llvm/tools/llvm-cov/SourceCoverageView.cpp
index 4170fb44e94..b71a35f8db0 100644
--- a/llvm/tools/llvm-cov/SourceCoverageView.cpp
+++ b/llvm/tools/llvm-cov/SourceCoverageView.cpp
@@ -74,7 +74,7 @@ Expected<SourceCoverageView::OwnedStream>
SourceCoverageView::createOutputStream(const CoverageViewOptions &Opts,
StringRef Path, StringRef Extension,
bool InToplevel) {
- if (Opts.ShowOutputDirectory == "")
+ if (!Opts.hasOutputDirectory())
return OwnedStream(&outs());
return createFileInDirectory(Opts.ShowOutputDirectory,
OpenPOWER on IntegriCloud