diff options
| author | Reid Kleckner <rnk@google.com> | 2017-07-17 20:28:06 +0000 |
|---|---|---|
| committer | Reid Kleckner <rnk@google.com> | 2017-07-17 20:28:06 +0000 |
| commit | a842cd75e2edf3b901835d4751f5ba3897da82dc (patch) | |
| tree | a116afb5c722c19f07e28efd34763b83746868c7 /llvm/tools | |
| parent | 0cf9e702bf813a571b54d5c35b793b14a66006fc (diff) | |
| download | bcm5719-llvm-a842cd75e2edf3b901835d4751f5ba3897da82dc.tar.gz bcm5719-llvm-a842cd75e2edf3b901835d4751f5ba3897da82dc.zip | |
[codeview] Remove TypeServerHandler and PDBTypeServerHandler
Summary:
Instead of wiring these through the CVTypeVisitor interface, clients
should inspect the CVTypeArray before visiting it and potentially load
up the type server's TPI stream if they need it.
No tests relied on this functionality because LLD was the only client.
Reviewers: ruiu
Subscribers: mgorny, hiraditya, zturner, llvm-commits
Differential Revision: https://reviews.llvm.org/D35394
llvm-svn: 308212
Diffstat (limited to 'llvm/tools')
| -rw-r--r-- | llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp | 4 | ||||
| -rw-r--r-- | llvm/tools/llvm-readobj/COFFDumper.cpp | 3 |
2 files changed, 3 insertions, 4 deletions
diff --git a/llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp b/llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp index 6aa08ff3cd8..f2bd194622e 100644 --- a/llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp +++ b/llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp @@ -956,8 +956,8 @@ static void mergePdbs() { SmallVector<TypeIndex, 128> IdMap; if (File.hasPDBTpiStream()) { auto &Tpi = ExitOnErr(File.getPDBTpiStream()); - ExitOnErr(codeview::mergeTypeRecords(MergedTpi, TypeMap, nullptr, - Tpi.typeArray())); + ExitOnErr( + codeview::mergeTypeRecords(MergedTpi, TypeMap, Tpi.typeArray())); } if (File.hasPDBIpiStream()) { auto &Ipi = ExitOnErr(File.getPDBIpiStream()); diff --git a/llvm/tools/llvm-readobj/COFFDumper.cpp b/llvm/tools/llvm-readobj/COFFDumper.cpp index 9fb3267e2f9..74c44116b12 100644 --- a/llvm/tools/llvm-readobj/COFFDumper.cpp +++ b/llvm/tools/llvm-readobj/COFFDumper.cpp @@ -1215,8 +1215,7 @@ void COFFDumper::mergeCodeViewTypes(TypeTableBuilder &CVIDs, error(object_error::parse_failed); } SmallVector<TypeIndex, 128> SourceToDest; - if (auto EC = mergeTypeAndIdRecords(CVIDs, CVTypes, SourceToDest, nullptr, - Types)) + if (auto EC = mergeTypeAndIdRecords(CVIDs, CVTypes, SourceToDest, Types)) return error(std::move(EC)); } } |

