summaryrefslogtreecommitdiffstats
path: root/llvm/tools
diff options
context:
space:
mode:
authorMatt Davis <Matthew.Davis@sony.com>2019-02-01 17:38:08 +0000
committerMatt Davis <Matthew.Davis@sony.com>2019-02-01 17:38:08 +0000
commit68fad505e2990c27e9580cb09cd55c76909143c6 (patch)
tree1d5c03666c90a9d3e9ba027d305b0306232190b7 /llvm/tools
parent123883807dfe583d85c4493d58f39275cc1ab6ba (diff)
downloadbcm5719-llvm-68fad505e2990c27e9580cb09cd55c76909143c6.tar.gz
bcm5719-llvm-68fad505e2990c27e9580cb09cd55c76909143c6.zip
[llvm-nm] Report '.comment' ELF sections as 'n' instead of '?'
Summary: The previous implementation reported `.comment` sections as '?' GNU uses 'n' which means "The symbol is a debugging symbol." `.note` sections are represented as 'n' too. The test related to this change was updated to CHECK-NEXT to ensure order and that we did not miss any symbols in the dump. Reviewers: jhenderson Reviewed By: jhenderson Subscribers: rupprecht, llvm-commits Differential Revision: https://reviews.llvm.org/D57544 llvm-svn: 352891
Diffstat (limited to 'llvm/tools')
-rw-r--r--llvm/tools/llvm-nm/llvm-nm.cpp1
1 files changed, 1 insertions, 0 deletions
diff --git a/llvm/tools/llvm-nm/llvm-nm.cpp b/llvm/tools/llvm-nm/llvm-nm.cpp
index 83620778359..3a83fdb1424 100644
--- a/llvm/tools/llvm-nm/llvm-nm.cpp
+++ b/llvm/tools/llvm-nm/llvm-nm.cpp
@@ -935,6 +935,7 @@ static char getSymbolNMTypeChar(ELFObjectFileBase &Obj,
return StringSwitch<char>(*Name)
.StartsWith(".debug", 'N')
.StartsWith(".note", 'n')
+ .StartsWith(".comment", 'n')
.Default('?');
}
OpenPOWER on IntegriCloud