[yaml2obj] Removing debug code that scribbled 0xDEADBEEF

Now that MachO load command fields are fully covered we can fill unaccounted for bytes with 0. That allows us to sparsely specify YAML to simplify tests.

Simplifying load_commands test accordingly.

llvm-svn: 270158

1 files changed, 3 insertions, 4 deletions

diff --git a/llvm/tools/yaml2obj/yaml2macho.cpp b/llvm/tools/yaml2obj/yaml2macho.cpp
index 2a1c6a7e9d2..6d71eef67bc 100644
--- a/llvm/tools/yaml2obj/yaml2macho.cpp
+++ b/llvm/tools/yaml2obj/yaml2macho.cpp
@@ -182,13 +182,12 @@ Error MachOWriter::writeLoadCommands(raw_ostream &OS) {
       BytesWritten += LC.ZeroPadBytes;
     }
 
+    // Fill remaining bytes with 0. This will only get hit in partially
+    // specified test cases.
     auto BytesRemaining = LC.Data.load_command_data.cmdsize - BytesWritten;
     if (BytesRemaining > 0) {
-      // TODO: Replace all this once the load command data is present in yaml.
-      // For now I fill with 0xDEADBEEF because it is easy to spot on a hex
-      // viewer.
       std::vector<uint32_t> FillData;
-      FillData.insert(FillData.begin(), BytesRemaining / 4 + 1, 0xDEADBEEFu);
+      FillData.insert(FillData.begin(), BytesRemaining, 0);
       OS.write(reinterpret_cast<char *>(FillData.data()), BytesRemaining);
     }
   }