diff options
author | Chris Bieneman <beanz@apple.com> | 2016-06-27 19:53:53 +0000 |
---|---|---|
committer | Chris Bieneman <beanz@apple.com> | 2016-06-27 19:53:53 +0000 |
commit | 8ff0c113575167809365d2de5f6a204ff9c9c2bb (patch) | |
tree | bcfa2a036127dcd47a729941ec0389ec8022af0c /llvm/tools/yaml2obj/yaml2coff.cpp | |
parent | f0fa61ffcfc8550f1b4282e456b3763d71b60c76 (diff) | |
download | bcm5719-llvm-8ff0c113575167809365d2de5f6a204ff9c9c2bb.tar.gz bcm5719-llvm-8ff0c113575167809365d2de5f6a204ff9c9c2bb.zip |
[yaml2obj] Remove --format option in favor of YAML tags
Summary:
Our YAML library's handling of tags isn't perfect, but it is good enough to get rid of the need for the --format argument to yaml2obj. This patch does exactly that.
Instead of requiring --format, it infers the format based on the tags found in the object file. The supported tags are:
!ELF
!COFF
!mach-o
!fat-mach-o
I have a corresponding patch that is quite large that fixes up all the in-tree test cases.
Reviewers: rafael, Bigcheese, compnerd, silvas
Subscribers: compnerd, llvm-commits
Differential Revision: http://reviews.llvm.org/D21711
llvm-svn: 273915
Diffstat (limited to 'llvm/tools/yaml2obj/yaml2coff.cpp')
-rw-r--r-- | llvm/tools/yaml2obj/yaml2coff.cpp | 11 |
1 files changed, 2 insertions, 9 deletions
diff --git a/llvm/tools/yaml2obj/yaml2coff.cpp b/llvm/tools/yaml2obj/yaml2coff.cpp index 1a1d07d7944..8f3f5217952 100644 --- a/llvm/tools/yaml2obj/yaml2coff.cpp +++ b/llvm/tools/yaml2obj/yaml2coff.cpp @@ -18,7 +18,7 @@ #include "llvm/ADT/StringMap.h" #include "llvm/ADT/StringSwitch.h" #include "llvm/Object/COFF.h" -#include "llvm/ObjectYAML/COFFYAML.h" +#include "llvm/ObjectYAML/ObjectYAML.h" #include "llvm/Support/Endian.h" #include "llvm/Support/MemoryBuffer.h" #include "llvm/Support/SourceMgr.h" @@ -532,14 +532,7 @@ static bool writeCOFF(COFFParser &CP, raw_ostream &OS) { return true; } -int yaml2coff(yaml::Input &YIn, raw_ostream &Out) { - COFFYAML::Object Doc; - YIn >> Doc; - if (YIn.error()) { - errs() << "yaml2obj: Failed to parse YAML file!\n"; - return 1; - } - +int yaml2coff(llvm::COFFYAML::Object &Doc, raw_ostream &Out) { COFFParser CP(Doc); if (!CP.parse()) { errs() << "yaml2obj: Failed to parse YAML file!\n"; |