diff options
author | Fangrui Song <maskray@google.com> | 2018-05-25 00:11:15 +0000 |
---|---|---|
committer | Fangrui Song <maskray@google.com> | 2018-05-25 00:11:15 +0000 |
commit | 3b7499d104158e54634ac01c0e6826af49edc16a (patch) | |
tree | 79a320fa4e72a065bbf6a224c059e09524341eab /llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp | |
parent | 7f0a05ada547b73a33f55d00a3fa984b2cd45a17 (diff) | |
download | bcm5719-llvm-3b7499d104158e54634ac01c0e6826af49edc16a.tar.gz bcm5719-llvm-3b7499d104158e54634ac01c0e6826af49edc16a.zip |
[llvm-symbolizer] Simplify. NFC
llvm-svn: 333247
Diffstat (limited to 'llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp')
-rw-r--r-- | llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp b/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp index e3fd22ef8db..1255e74ea37 100644 --- a/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp +++ b/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp @@ -101,22 +101,17 @@ static bool error(Expected<T> &ResOrErr) { static bool parseCommand(StringRef InputString, bool &IsData, std::string &ModuleName, uint64_t &ModuleOffset) { - const char *kDataCmd = "DATA "; - const char *kCodeCmd = "CODE "; const char kDelimiters[] = " \n\r"; - IsData = false; ModuleName = ""; - const char *pos = InputString.data(); - if (strncmp(pos, kDataCmd, strlen(kDataCmd)) == 0) { - IsData = true; - pos += strlen(kDataCmd); - } else if (strncmp(pos, kCodeCmd, strlen(kCodeCmd)) == 0) { + if (InputString.consume_front("CODE ")) { IsData = false; - pos += strlen(kCodeCmd); + } else if (InputString.consume_front("DATA ")) { + IsData = true; } else { // If no cmd, assume it's CODE. IsData = false; } + const char *pos = InputString.data(); // Skip delimiters and parse input filename (if needed). if (ClBinaryName == "") { pos += strspn(pos, kDelimiters); @@ -183,7 +178,7 @@ int main(int argc, char **argv) { if (ClPrintAddress) { outs() << "0x"; outs().write_hex(ModuleOffset); - StringRef Delimiter = (ClPrettyPrint == true) ? ": " : "\n"; + StringRef Delimiter = ClPrettyPrint ? ": " : "\n"; outs() << Delimiter; } if (IsData) { |