summaryrefslogtreecommitdiffstats
path: root/llvm/tools/llvm-readobj
diff options
context:
space:
mode:
authorRafael Espindola <rafael.espindola@gmail.com>2015-06-26 12:18:49 +0000
committerRafael Espindola <rafael.espindola@gmail.com>2015-06-26 12:18:49 +0000
commit2fa80cc5fde697acfc8c69c38e2648aee063d5b7 (patch)
treeed0c7c8b7d72f217cfd0af85bef7b4a3f0027613 /llvm/tools/llvm-readobj
parent99a9343ae6b9244b8933cef099e6fff70610f59b (diff)
downloadbcm5719-llvm-2fa80cc5fde697acfc8c69c38e2648aee063d5b7.tar.gz
bcm5719-llvm-2fa80cc5fde697acfc8c69c38e2648aee063d5b7.zip
Simplify getSymbolType.
This is still a really odd function. Most calls are in object format specific contexts and should probably be replaced with a more direct query, but at least now this is not too obnoxious to use. llvm-svn: 240777
Diffstat (limited to 'llvm/tools/llvm-readobj')
-rw-r--r--llvm/tools/llvm-readobj/ARMWinEHPrinter.cpp9
1 files changed, 2 insertions, 7 deletions
diff --git a/llvm/tools/llvm-readobj/ARMWinEHPrinter.cpp b/llvm/tools/llvm-readobj/ARMWinEHPrinter.cpp
index 62252fcda5f..d00704fdf59 100644
--- a/llvm/tools/llvm-readobj/ARMWinEHPrinter.cpp
+++ b/llvm/tools/llvm-readobj/ARMWinEHPrinter.cpp
@@ -198,13 +198,8 @@ Decoder::getSectionContaining(const COFFObjectFile &COFF, uint64_t VA) {
ErrorOr<object::SymbolRef> Decoder::getSymbol(const COFFObjectFile &COFF,
uint64_t VA, bool FunctionOnly) {
for (const auto &Symbol : COFF.symbols()) {
- if (FunctionOnly) {
- SymbolRef::Type Type;
- if (std::error_code EC = Symbol.getType(Type))
- return EC;
- if (Type != SymbolRef::ST_Function)
- continue;
- }
+ if (FunctionOnly && Symbol.getType() != SymbolRef::ST_Function)
+ continue;
uint64_t Address;
if (std::error_code EC = Symbol.getAddress(Address))
OpenPOWER on IntegriCloud