diff options
| author | David Majnemer <david.majnemer@gmail.com> | 2014-09-26 22:32:16 +0000 |
|---|---|---|
| committer | David Majnemer <david.majnemer@gmail.com> | 2014-09-26 22:32:16 +0000 |
| commit | dac39857d6545e32f20f0735a04b934f36b6c1d9 (patch) | |
| tree | a969577804c80a12810628209ad39403b5edd65b /llvm/tools/llvm-readobj/COFFDumper.cpp | |
| parent | b774a0e75071f4b32e741297b4e017615b01a8a9 (diff) | |
| download | bcm5719-llvm-dac39857d6545e32f20f0735a04b934f36b6c1d9.tar.gz bcm5719-llvm-dac39857d6545e32f20f0735a04b934f36b6c1d9.zip | |
Object: BSS/virtual sections don't have contents
Users of getSectionContents shouldn't try to pass in BSS or virtual
sections. In all instances, this is a bug in the code calling this
routine.
N.B. Some COFF implementations (like CL) will mark their BSS sections as
taking space on disk. This would confuse COFFObjectFile into thinking
the section is larger than the file.
llvm-svn: 218549
Diffstat (limited to 'llvm/tools/llvm-readobj/COFFDumper.cpp')
| -rw-r--r-- | llvm/tools/llvm-readobj/COFFDumper.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/llvm/tools/llvm-readobj/COFFDumper.cpp b/llvm/tools/llvm-readobj/COFFDumper.cpp index 99a374d5a6a..3d71d832f99 100644 --- a/llvm/tools/llvm-readobj/COFFDumper.cpp +++ b/llvm/tools/llvm-readobj/COFFDumper.cpp @@ -635,7 +635,8 @@ void COFFDumper::printSections() { if (Name == ".debug$S" && opts::CodeViewLineTables) printCodeViewLineTables(Sec); - if (opts::SectionData) { + if (opts::SectionData && + !(Section->Characteristics & COFF::IMAGE_SCN_CNT_UNINITIALIZED_DATA)) { StringRef Data; if (error(Sec.getContents(Data))) break; |
