diff options
| author | Raphael Isemann <teemperor@gmail.com> | 2019-05-02 10:12:56 +0000 |
|---|---|---|
| committer | Raphael Isemann <teemperor@gmail.com> | 2019-05-02 10:12:56 +0000 |
| commit | 71569d0d523465203ba465a89c37d75075a5e2c2 (patch) | |
| tree | c4fb9169881afb91cdb29de5d5736b7214ab6721 /llvm/tools/llvm-readobj/COFFDumper.cpp | |
| parent | 1136ea2d446dcf02d11cb1e9862e9d290eaa8a68 (diff) | |
| download | bcm5719-llvm-71569d0d523465203ba465a89c37d75075a5e2c2.tar.gz bcm5719-llvm-71569d0d523465203ba465a89c37d75075a5e2c2.zip | |
Inject only relevant local variables in the expression evaluation context
Summary:
In r259902, LLDB started injecting all the locals in every expression
evaluation. This fixed a bunch of issues, but also caused others, mostly
performance regressions on some codebases. The regressions were bad
enough that we added a setting in r274783 to control the behavior and
we have been shipping with the setting off to avoid the perf regressions.
This patch changes the logic injecting the local variables to only inject
the ones present in the expression typed by the user. The approach is
fairly simple and just scans the typed expression for every local name.
Hopefully this gives us the best of both world as it just realizes the
types of the variables really used by the expression.
Landing this requires the 2 other issues I pointed out today to be addressed
but I wanted to gather comments right away.
Original patch by Frédéric Riss!
Reviewers: jingham, clayborg, friss, shafik
Reviewed By: jingham, clayborg
Subscribers: teemperor, labath, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D46551
llvm-svn: 359773
Diffstat (limited to 'llvm/tools/llvm-readobj/COFFDumper.cpp')
0 files changed, 0 insertions, 0 deletions
