summaryrefslogtreecommitdiffstats
path: root/llvm/tools/llvm-objdump
diff options
context:
space:
mode:
authorNick Kledzik <kledzik@apple.com>2014-09-02 18:50:24 +0000
committerNick Kledzik <kledzik@apple.com>2014-09-02 18:50:24 +0000
commitac7cbdc9b14fda3d814d696631aefcb5d41ce726 (patch)
tree145a9492a78c66bb5510ac98e5bfdbad6e23170a /llvm/tools/llvm-objdump
parent9d412ed41e3bce464fca95355a112e5292df9371 (diff)
downloadbcm5719-llvm-ac7cbdc9b14fda3d814d696631aefcb5d41ce726.tar.gz
bcm5719-llvm-ac7cbdc9b14fda3d814d696631aefcb5d41ce726.zip
Code review tweaks
llvm-svn: 216931
Diffstat (limited to 'llvm/tools/llvm-objdump')
-rw-r--r--llvm/tools/llvm-objdump/MachODump.cpp34
1 files changed, 17 insertions, 17 deletions
diff --git a/llvm/tools/llvm-objdump/MachODump.cpp b/llvm/tools/llvm-objdump/MachODump.cpp
index bfff4456b01..fe9513a4c77 100644
--- a/llvm/tools/llvm-objdump/MachODump.cpp
+++ b/llvm/tools/llvm-objdump/MachODump.cpp
@@ -1789,8 +1789,8 @@ void llvm::printMachOFileHeader(const object::ObjectFile *Obj) {
//===----------------------------------------------------------------------===//
void llvm::printMachOExportsTrie(const object::MachOObjectFile *Obj) {
- for (const llvm::object::ExportEntry &entry : Obj->exports()) {
- uint64_t Flags = entry.flags();
+ for (const llvm::object::ExportEntry &Entry : Obj->exports()) {
+ uint64_t Flags = Entry.flags();
bool ReExport = (Flags & MachO::EXPORT_SYMBOL_FLAGS_REEXPORT);
bool WeakDef = (Flags & MachO::EXPORT_SYMBOL_FLAGS_WEAK_DEFINITION);
bool ThreadLocal = ((Flags & MachO::EXPORT_SYMBOL_FLAGS_KIND_MASK) ==
@@ -1802,43 +1802,43 @@ void llvm::printMachOExportsTrie(const object::MachOObjectFile *Obj) {
outs() << "[re-export] ";
else
outs()
- << format("0x%08llX ", entry.address()); // FIXME:add in base address
- outs() << entry.name();
+ << format("0x%08llX ", Entry.address()); // FIXME:add in base address
+ outs() << Entry.name();
if (WeakDef || ThreadLocal || Resolver || Abs) {
- bool needComma = false;
+ bool NeedsComma = false;
printf(" [");
if (WeakDef) {
outs() << "weak_def";
- needComma = true;
+ NeedsComma = true;
}
if (ThreadLocal) {
- if (needComma)
+ if (NeedsComma)
outs() << ", ";
outs() << "per-thread";
- needComma = true;
+ NeedsComma = true;
}
if (Abs) {
- if (needComma)
+ if (NeedsComma)
outs() << ", ";
outs() << "absolute";
- needComma = true;
+ NeedsComma = true;
}
if (Resolver) {
- if (needComma)
+ if (NeedsComma)
outs() << ", ";
- outs() << format("resolver=0x%08llX", entry.other());
- needComma = true;
+ outs() << format("resolver=0x%08llX", Entry.other());
+ NeedsComma = true;
}
outs() << "]";
}
if (ReExport) {
StringRef DylibName = "unknown";
- int ordinal = entry.other() - 1;
- Obj->getLibraryShortNameByIndex(ordinal, DylibName);
- if (entry.otherName().empty())
+ int Ordinal = Entry.other() - 1;
+ Obj->getLibraryShortNameByIndex(Ordinal, DylibName);
+ if (Entry.otherName().empty())
outs() << " (from " << DylibName << ")";
else
- outs() << " (" << entry.otherName() << " from " << DylibName << ")";
+ outs() << " (" << Entry.otherName() << " from " << DylibName << ")";
}
outs() << "\n";
}
OpenPOWER on IntegriCloud