[llvm-objdump] improve error reporting of bad mach-o ordinals

llvm-svn: 217909

1 files changed, 8 insertions, 2 deletions

diff --git a/llvm/tools/llvm-objdump/MachODump.cpp b/llvm/tools/llvm-objdump/MachODump.cpp
index 871e7d16ece..602e8002800 100644
--- a/llvm/tools/llvm-objdump/MachODump.cpp
+++ b/llvm/tools/llvm-objdump/MachODump.cpp
@@ -2446,9 +2446,15 @@ static StringRef ordinalName(const object::MachOObjectFile *Obj, int Ordinal) {
   case MachO::BIND_SPECIAL_DYLIB_FLAT_LOOKUP:
     return "flat-namespace";
   default:
-    Obj->getLibraryShortNameByIndex(Ordinal-1, DylibName);
-    return DylibName;
+    if (Ordinal > 0) {
+      std::error_code EC = Obj->getLibraryShortNameByIndex(Ordinal-1, 
+                                                           DylibName);
+      if (EC)
+        return "<<ordinal too big>>";
+      return DylibName;
+    }
   }
+  return "<<unknown special ordinal>>";
 }
 
 //===----------------------------------------------------------------------===//