summaryrefslogtreecommitdiffstats
path: root/llvm/tools/llvm-objcopy/Object.cpp
diff options
context:
space:
mode:
authorPaul Semel <semelpaul@gmail.com>2018-06-01 16:19:46 +0000
committerPaul Semel <semelpaul@gmail.com>2018-06-01 16:19:46 +0000
commit46201fb7bc31ed90409440878ccbe567efd33cd8 (patch)
treecb0ead3bb6726309d2af8700d78e060e2dbb697a /llvm/tools/llvm-objcopy/Object.cpp
parentbc68385dad322f80a5b064db2f4e0fd3f9c21781 (diff)
downloadbcm5719-llvm-46201fb7bc31ed90409440878ccbe567efd33cd8.tar.gz
bcm5719-llvm-46201fb7bc31ed90409440878ccbe567efd33cd8.zip
[llvm-objcopy] Fix null symbol handling
This fixes the bug where strip-all option was leading to a malformed outputted ELF file. Differential Revision: https://reviews.llvm.org/D47414 llvm-svn: 333772
Diffstat (limited to 'llvm/tools/llvm-objcopy/Object.cpp')
-rw-r--r--llvm/tools/llvm-objcopy/Object.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/llvm/tools/llvm-objcopy/Object.cpp b/llvm/tools/llvm-objcopy/Object.cpp
index 6b656c6b2f7..606e0321288 100644
--- a/llvm/tools/llvm-objcopy/Object.cpp
+++ b/llvm/tools/llvm-objcopy/Object.cpp
@@ -200,8 +200,8 @@ void SymbolTableSection::removeSectionReferences(const SectionBase *Sec) {
}
void SymbolTableSection::updateSymbols(function_ref<void(Symbol &)> Callable) {
- for (auto &Sym : Symbols)
- Callable(*Sym);
+ std::for_each(std::begin(Symbols) + 1, std::end(Symbols),
+ [Callable](SymPtr &Sym) { Callable(*Sym); });
std::stable_partition(
std::begin(Symbols), std::end(Symbols),
[](const SymPtr &Sym) { return Sym->Binding == STB_LOCAL; });
@@ -211,7 +211,7 @@ void SymbolTableSection::updateSymbols(function_ref<void(Symbol &)> Callable) {
void SymbolTableSection::removeSymbols(
function_ref<bool(const Symbol &)> ToRemove) {
Symbols.erase(
- std::remove_if(std::begin(Symbols), std::end(Symbols),
+ std::remove_if(std::begin(Symbols) + 1, std::end(Symbols),
[ToRemove](const SymPtr &Sym) { return ToRemove(*Sym); }),
std::end(Symbols));
Size = Symbols.size() * EntrySize;
OpenPOWER on IntegriCloud