Simplify the handling of iterators in ObjectFile.

None of the object file formats reported error on iterator increment. In
retrospect, that is not too surprising: no object format stores symbols or
sections in a linked list or other structure that requires chasing pointers.
As a consequence, all error checking can be done on begin() and end().

This reduces the text segment of bin/llvm-readobj in my machine from 521233 to
518526 bytes.

llvm-svn: 200442

1 files changed, 1 insertions, 4 deletions

diff --git a/llvm/tools/llvm-nm/llvm-nm.cpp b/llvm/tools/llvm-nm/llvm-nm.cpp
index 495a71b0e90..da221d133a2 100644
--- a/llvm/tools/llvm-nm/llvm-nm.cpp
+++ b/llvm/tools/llvm-nm/llvm-nm.cpp
@@ -532,16 +532,13 @@ static char getNMTypeChar(ObjectFile *Obj, symbol_iterator I) {
 }
 
 static void dumpSymbolNamesFromObject(ObjectFile *Obj) {
-  error_code EC;
   symbol_iterator IBegin = Obj->begin_symbols();
   symbol_iterator IEnd = Obj->end_symbols();
   if (DynamicSyms) {
     IBegin = Obj->begin_dynamic_symbols();
     IEnd = Obj->end_dynamic_symbols();
   }
-  for (symbol_iterator I = IBegin; I != IEnd; I.increment(EC)) {
-    if (error(EC))
-      break;
+  for (symbol_iterator I = IBegin; I != IEnd; ++I) {
     uint32_t SymFlags;
     if (error(I->getFlags(SymFlags)))
       break;