diff options
| author | Peter Collingbourne <peter@pcc.me.uk> | 2017-04-17 17:51:36 +0000 |
|---|---|---|
| committer | Peter Collingbourne <peter@pcc.me.uk> | 2017-04-17 17:51:36 +0000 |
| commit | a0f371a106f003bb6575bc8f19ab82121d8bc1c4 (patch) | |
| tree | 7367ce107322299d35983d4e5a7fd4c98dff7709 /llvm/tools/llvm-modextract | |
| parent | dc77b2e960b6b6d4622c89ee8d324848ac6a0609 (diff) | |
| download | bcm5719-llvm-a0f371a106f003bb6575bc8f19ab82121d8bc1c4.tar.gz bcm5719-llvm-a0f371a106f003bb6575bc8f19ab82121d8bc1c4.zip | |
Bitcode: Add a string table to the bitcode format.
Add a top-level STRTAB block containing a string table blob, and start storing
strings for module codes FUNCTION, GLOBALVAR, ALIAS, IFUNC and COMDAT in
the string table.
This change allows us to share names between globals and comdats as well
as between modules, and improves the efficiency of loading bitcode files by
no longer using a bit encoding for symbol names. Once we start writing the
irsymtab to the bitcode file we will also be able to share strings between
it and the module.
On my machine, link time for Chromium for Linux with ThinLTO decreases by
about 7% for no-op incremental builds or about 1% for full builds. Total
bitcode file size decreases by about 3%.
As discussed on llvm-dev:
http://lists.llvm.org/pipermail/llvm-dev/2017-April/111732.html
Differential Revision: https://reviews.llvm.org/D31838
llvm-svn: 300464
Diffstat (limited to 'llvm/tools/llvm-modextract')
| -rw-r--r-- | llvm/tools/llvm-modextract/llvm-modextract.cpp | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/llvm/tools/llvm-modextract/llvm-modextract.cpp b/llvm/tools/llvm-modextract/llvm-modextract.cpp index 6c2e364be44..58cede1374e 100644 --- a/llvm/tools/llvm-modextract/llvm-modextract.cpp +++ b/llvm/tools/llvm-modextract/llvm-modextract.cpp @@ -59,9 +59,12 @@ int main(int argc, char **argv) { ExitOnErr(errorCodeToError(EC)); if (BinaryExtract) { - SmallVector<char, 0> Header; - BitcodeWriter Writer(Header); - Out->os() << Header << Ms[ModuleIndex].getBuffer(); + SmallVector<char, 0> Result; + BitcodeWriter Writer(Result); + Result.append(Ms[ModuleIndex].getBuffer().begin(), + Ms[ModuleIndex].getBuffer().end()); + Writer.copyStrtab(Ms[ModuleIndex].getStrtab()); + Out->os() << Result; Out->keep(); return 0; } |

