diff options
| author | Simon Atanasyan <simon@atanasyan.com> | 2018-04-24 16:14:00 +0000 |
|---|---|---|
| committer | Simon Atanasyan <simon@atanasyan.com> | 2018-04-24 16:14:00 +0000 |
| commit | 9df3be3ccb175beb960d7c8456c89c8d94c4ff2d (patch) | |
| tree | b3cd6ddb5fcd4d1c1d1dfa2cd74f3f74e451dae9 /llvm/tools/llvm-mca | |
| parent | 510af48e5d6089adb105afcc7c4521b0509143d6 (diff) | |
| download | bcm5719-llvm-9df3be3ccb175beb960d7c8456c89c8d94c4ff2d.tar.gz bcm5719-llvm-9df3be3ccb175beb960d7c8456c89c8d94c4ff2d.zip | |
[mips] Show an error if register number is out of range
Current code does not check that a register number is in the 0-31 range.
Sometimes the parser checks that later for some kinds of instructions,
but that leads to unclear / incorrect error messages like that:
% cat test.s
.text
lb $4, 8($32)
% llvm-mc test.s -triple=mips64-unknown-linux
test.s:2:10: error: expected memory with 16-bit signed offset
lb $4, 8($32)
^
Sometimes the parser just crashes:
% cat test.s
.text
lw $4, 8($32)
% llvm-mc test.s -triple=mips64-unknown-linux
This patch resolves the problem by checking that register number after
'$' sign is in the 0-31 range. If the number is out of the range the
parser shows the `invalid register number` error, but treats invalid
register number as a normal one to continue parsing and catch other
possible errors.
Differential Revision: https://reviews.llvm.org/D45919
llvm-svn: 330732
Diffstat (limited to 'llvm/tools/llvm-mca')
0 files changed, 0 insertions, 0 deletions

