diff options
| author | Sam McCall <sam.mccall@gmail.com> | 2018-11-08 17:42:16 +0000 |
|---|---|---|
| committer | Sam McCall <sam.mccall@gmail.com> | 2018-11-08 17:42:16 +0000 |
| commit | 3c1f4903b77752aa6fb820e32715a824b4e82ead (patch) | |
| tree | eace8522d4cb99aaed0f1aea85de960105c947d1 /llvm/tools/llvm-mca/lib/Context.cpp | |
| parent | 08b64d60fe0a5166972bbf72b38b93b2174bf62a (diff) | |
| download | bcm5719-llvm-3c1f4903b77752aa6fb820e32715a824b4e82ead.tar.gz bcm5719-llvm-3c1f4903b77752aa6fb820e32715a824b4e82ead.zip | |
[clang-tidy] Untangle layering in ClangTidyDiagnosticConsumer somewhat. NFC
Summary:
Clang's hierarchy is CompilerInstance -> DiagnosticsEngine -> DiagnosticConsumer.
(Ownership is optional/shared, but this structure is fairly clear).
Currently ClangTidyDiagnosticConsumer *owns* the DiagnosticsEngine:
- this inverts the hierarchy, which is confusing
- this means ClangTidyDiagnosticConsumer() mutates the passed-in context, which
is both surprising and limits flexibility
- it's not possible to use a different DiagnosticsEngine with ClangTidy
This means a little bit more code in the places ClangTidy is used standalone,
but more flexibility in using ClangTidy with other diagnostics configurations.
Reviewers: hokein
Subscribers: xazax.hun, cfe-commits
Differential Revision: https://reviews.llvm.org/D54033
llvm-svn: 346418
Diffstat (limited to 'llvm/tools/llvm-mca/lib/Context.cpp')
0 files changed, 0 insertions, 0 deletions
