diff options
| author | Rui Ueyama <ruiu@google.com> | 2019-08-02 04:48:30 +0000 |
|---|---|---|
| committer | Rui Ueyama <ruiu@google.com> | 2019-08-02 04:48:30 +0000 |
| commit | a52f982f1cd98ebf94abb5deb5244f460ddad2d1 (patch) | |
| tree | 61799d68dd515bda1a6bd6d7b70812e96dbe9ded /llvm/tools/llvm-mca/Views/TimelineView.cpp | |
| parent | 9131e925fd6b5010a9e797342a09141306183ed6 (diff) | |
| download | bcm5719-llvm-a52f982f1cd98ebf94abb5deb5244f460ddad2d1.tar.gz bcm5719-llvm-a52f982f1cd98ebf94abb5deb5244f460ddad2d1.zip | |
Improve raw_ostream so that you can "write" colors using operator<<
1. raw_ostream supports ANSI colors so that you can write messages to
the termina with colors. Previously, in order to change and reset
color, you had to call `changeColor` and `resetColor` functions,
respectively.
So, if you print out "error: " in red, for example, you had to do
something like this:
OS.changeColor(raw_ostream::RED);
OS << "error: ";
OS.resetColor();
With this patch, you can write the same code as follows:
OS << raw_ostream::RED << "error: " << raw_ostream::RESET;
2. Add a boolean flag to raw_ostream so that you can disable colored
output. If you disable colors, changeColor, operator<<(Color),
resetColor and other color-related functions have no effect.
Most LLVM tools automatically prints out messages using colors, and
you can disable it by passing a flag such as `--disable-colors`.
This new flag makes it easy to write code that works that way.
Differential Revision: https://reviews.llvm.org/D65564
llvm-svn: 367649
Diffstat (limited to 'llvm/tools/llvm-mca/Views/TimelineView.cpp')
| -rw-r--r-- | llvm/tools/llvm-mca/Views/TimelineView.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/llvm/tools/llvm-mca/Views/TimelineView.cpp b/llvm/tools/llvm-mca/Views/TimelineView.cpp index fe3f16ba344..09b6b2a3efe 100644 --- a/llvm/tools/llvm-mca/Views/TimelineView.cpp +++ b/llvm/tools/llvm-mca/Views/TimelineView.cpp @@ -103,8 +103,8 @@ void TimelineView::onEvent(const HWInstructionEvent &Event) { LastCycle = std::max(LastCycle, CurrentCycle); } -static raw_ostream::Colors chooseColor(unsigned CumulativeCycles, - unsigned Executions, int BufferSize) { +static raw_ostream::Color chooseColor(unsigned CumulativeCycles, + unsigned Executions, int BufferSize) { if (CumulativeCycles && BufferSize < 0) return raw_ostream::MAGENTA; unsigned Size = static_cast<unsigned>(BufferSize); @@ -120,7 +120,7 @@ static void tryChangeColor(raw_ostream &OS, unsigned Cycles, if (!OS.has_colors()) return; - raw_ostream::Colors Color = chooseColor(Cycles, Executions, BufferSize); + raw_ostream::Color Color = chooseColor(Cycles, Executions, BufferSize); if (Color == raw_ostream::SAVEDCOLOR) { OS.resetColor(); return; |

