summaryrefslogtreecommitdiffstats
path: root/llvm/tools/llvm-mc/llvm-mc.cpp
diff options
context:
space:
mode:
authorDavide Italiano <davide@freebsd.org>2015-09-14 17:10:01 +0000
committerDavide Italiano <davide@freebsd.org>2015-09-14 17:10:01 +0000
commit2c007d050aad89d444c465de5670f08dd90d8c21 (patch)
treecdbb2ed674934b7e127ad1f81671d12425064e7d /llvm/tools/llvm-mc/llvm-mc.cpp
parent69f3788c36f90432cf130fa974fffc517d241742 (diff)
downloadbcm5719-llvm-2c007d050aad89d444c465de5670f08dd90d8c21.tar.gz
bcm5719-llvm-2c007d050aad89d444c465de5670f08dd90d8c21.zip
[llvm-mc] Better error handling in ENOENT case + test.
This is a follow up to r247518. As a general note, I think we could do a much better job testing for error conditions in tools. I already anticipated in a previous mail, but while implementing this I noticed that the code coverage we have for error checking is pretty low. I can arbitrarily remove checks from several tools and the suite still passes. Differential Revision: http://reviews.llvm.org/D12846 llvm-svn: 247582
Diffstat (limited to 'llvm/tools/llvm-mc/llvm-mc.cpp')
-rw-r--r--llvm/tools/llvm-mc/llvm-mc.cpp7
1 files changed, 1 insertions, 6 deletions
diff --git a/llvm/tools/llvm-mc/llvm-mc.cpp b/llvm/tools/llvm-mc/llvm-mc.cpp
index 678ad360330..6e6b748c3d2 100644
--- a/llvm/tools/llvm-mc/llvm-mc.cpp
+++ b/llvm/tools/llvm-mc/llvm-mc.cpp
@@ -395,15 +395,10 @@ int main(int argc, char **argv) {
// construct the Triple object.
Triple TheTriple(TripleName);
- if (InputFilename != "-" && !sys::fs::exists(InputFilename)) {
- errs() << ProgName << ": '" << InputFilename << "': "
- << "No such file\n";
- return 1;
- }
ErrorOr<std::unique_ptr<MemoryBuffer>> BufferPtr =
MemoryBuffer::getFileOrSTDIN(InputFilename);
if (std::error_code EC = BufferPtr.getError()) {
- errs() << ProgName << ": " << EC.message() << '\n';
+ errs() << InputFilename << ": " << EC.message() << '\n';
return 1;
}
MemoryBuffer *Buffer = BufferPtr->get();
OpenPOWER on IntegriCloud