diff options
author | Rui Ueyama <ruiu@google.com> | 2019-08-02 04:48:30 +0000 |
---|---|---|
committer | Rui Ueyama <ruiu@google.com> | 2019-08-02 04:48:30 +0000 |
commit | a52f982f1cd98ebf94abb5deb5244f460ddad2d1 (patch) | |
tree | 61799d68dd515bda1a6bd6d7b70812e96dbe9ded /llvm/tools/llvm-cov/SourceCoverageViewText.cpp | |
parent | 9131e925fd6b5010a9e797342a09141306183ed6 (diff) | |
download | bcm5719-llvm-a52f982f1cd98ebf94abb5deb5244f460ddad2d1.tar.gz bcm5719-llvm-a52f982f1cd98ebf94abb5deb5244f460ddad2d1.zip |
Improve raw_ostream so that you can "write" colors using operator<<
1. raw_ostream supports ANSI colors so that you can write messages to
the termina with colors. Previously, in order to change and reset
color, you had to call `changeColor` and `resetColor` functions,
respectively.
So, if you print out "error: " in red, for example, you had to do
something like this:
OS.changeColor(raw_ostream::RED);
OS << "error: ";
OS.resetColor();
With this patch, you can write the same code as follows:
OS << raw_ostream::RED << "error: " << raw_ostream::RESET;
2. Add a boolean flag to raw_ostream so that you can disable colored
output. If you disable colors, changeColor, operator<<(Color),
resetColor and other color-related functions have no effect.
Most LLVM tools automatically prints out messages using colors, and
you can disable it by passing a flag such as `--disable-colors`.
This new flag makes it easy to write code that works that way.
Differential Revision: https://reviews.llvm.org/D65564
llvm-svn: 367649
Diffstat (limited to 'llvm/tools/llvm-cov/SourceCoverageViewText.cpp')
-rw-r--r-- | llvm/tools/llvm-cov/SourceCoverageViewText.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/tools/llvm-cov/SourceCoverageViewText.cpp b/llvm/tools/llvm-cov/SourceCoverageViewText.cpp index fcabee2ee69..f73b91a8511 100644 --- a/llvm/tools/llvm-cov/SourceCoverageViewText.cpp +++ b/llvm/tools/llvm-cov/SourceCoverageViewText.cpp @@ -101,7 +101,7 @@ void SourceCoverageViewText::renderLine(raw_ostream &OS, LineRef L, auto *WrappedSegment = LCS.getWrappedSegment(); CoverageSegmentArray Segments = LCS.getLineSegments(); - Optional<raw_ostream::Colors> Highlight; + Optional<raw_ostream::Color> Highlight; SmallVector<std::pair<unsigned, unsigned>, 2> HighlightedRanges; // The first segment overlaps from a previous line, so we treat it specially. |