diff options
author | Vedant Kumar <vsk@apple.com> | 2017-09-25 23:10:03 +0000 |
---|---|---|
committer | Vedant Kumar <vsk@apple.com> | 2017-09-25 23:10:03 +0000 |
commit | feb3f5272f3662f47353916edb08751660100036 (patch) | |
tree | bc9ba33d29c7c31a1f33840ba8617558f3ab8d24 /llvm/tools/llvm-cov/CodeCoverage.cpp | |
parent | cbbcf2f843b887764a32ffec60e3c46ee7de620a (diff) | |
download | bcm5719-llvm-feb3f5272f3662f47353916edb08751660100036.tar.gz bcm5719-llvm-feb3f5272f3662f47353916edb08751660100036.zip |
[llvm-cov] Warn if -show-functions is used without query files
llvm-cov's report mode does not print any output when -show-functions is
specified and no source files are specified. This can be surprising, so
the tool should at least print out an error message when this happens.
rdar://problem/34636859
llvm-svn: 314175
Diffstat (limited to 'llvm/tools/llvm-cov/CodeCoverage.cpp')
-rw-r--r-- | llvm/tools/llvm-cov/CodeCoverage.cpp | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/llvm/tools/llvm-cov/CodeCoverage.cpp b/llvm/tools/llvm-cov/CodeCoverage.cpp index ed87e9e8e61..1ea54a8cffd 100644 --- a/llvm/tools/llvm-cov/CodeCoverage.cpp +++ b/llvm/tools/llvm-cov/CodeCoverage.cpp @@ -931,10 +931,17 @@ int CodeCoverageTool::report(int argc, const char **argv, return 1; CoverageReport Report(ViewOpts, *Coverage.get()); - if (!ShowFunctionSummaries) + if (!ShowFunctionSummaries) { Report.renderFileReports(llvm::outs()); - else + } else { + if (SourceFiles.empty()) { + error("Source files must be specified when -show-functions=true is " + "specified"); + return 1; + } + Report.renderFunctionReports(SourceFiles, DC, llvm::outs()); + } return 0; } |