diff options
| author | Serge Guelton <sguelton@quarkslab.com> | 2017-04-11 15:01:18 +0000 |
|---|---|---|
| committer | Serge Guelton <sguelton@quarkslab.com> | 2017-04-11 15:01:18 +0000 |
| commit | 59a2d7b9093617aff6b6f147ba267bc788aa08b7 (patch) | |
| tree | 2ffc9141cd19edf0d123828627a9f1e8c4c19907 /llvm/tools/bugpoint | |
| parent | de3b9a2ecc7e9ebe3fc1780aede0223821c52d2a (diff) | |
| download | bcm5719-llvm-59a2d7b9093617aff6b6f147ba267bc788aa08b7.tar.gz bcm5719-llvm-59a2d7b9093617aff6b6f147ba267bc788aa08b7.zip | |
Module::getOrInsertFunction is using C-style vararg instead of variadic templates.
From a user prospective, it forces the use of an annoying nullptr to mark the end of the vararg, and there's not type checking on the arguments.
The variadic template is an obvious solution to both issues.
Differential Revision: https://reviews.llvm.org/D31070
llvm-svn: 299949
Diffstat (limited to 'llvm/tools/bugpoint')
| -rw-r--r-- | llvm/tools/bugpoint/Miscompilation.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/tools/bugpoint/Miscompilation.cpp b/llvm/tools/bugpoint/Miscompilation.cpp index ff4e8e016ef..80f4cea2348 100644 --- a/llvm/tools/bugpoint/Miscompilation.cpp +++ b/llvm/tools/bugpoint/Miscompilation.cpp @@ -841,7 +841,7 @@ static void CleanupAndPrepareModules(BugDriver &BD, // Prototype: void *getPointerToNamedFunction(const char* Name) Constant *resolverFunc = Safe->getOrInsertFunction( "getPointerToNamedFunction", Type::getInt8PtrTy(Safe->getContext()), - Type::getInt8PtrTy(Safe->getContext()), (Type *)nullptr); + Type::getInt8PtrTy(Safe->getContext())); // Use the function we just added to get addresses of functions we need. for (Module::iterator F = Safe->begin(), E = Safe->end(); F != E; ++F) { |
