summaryrefslogtreecommitdiffstats
path: root/llvm/test
diff options
context:
space:
mode:
authorChris Lattner <sabre@nondot.org>2009-06-27 04:16:01 +0000
committerChris Lattner <sabre@nondot.org>2009-06-27 04:16:01 +0000
commitfea81da433b4540df545692ff9223213fe18d594 (patch)
tree5a0d9624120a18156f1cf319fa9c3cb67b895fed /llvm/test
parentdf92e147c925b8c11c913f51b238f67bd99fa374 (diff)
downloadbcm5719-llvm-fea81da433b4540df545692ff9223213fe18d594.tar.gz
bcm5719-llvm-fea81da433b4540df545692ff9223213fe18d594.zip
Reimplement rip-relative addressing in the X86-64 backend. The new
implementation primarily differs from the former in that the asmprinter doesn't make a zillion decisions about whether or not something will be RIP relative or not. Instead, those decisions are made by isel lowering and propagated through to the asm printer. To achieve this, we: 1. Represent RIP relative addresses by setting the base of the X86 addr mode to X86::RIP. 2. When ISel Lowering decides that it is safe to use RIP, it lowers to X86ISD::WrapperRIP. When it is unsafe to use RIP, it lowers to X86ISD::Wrapper as before. 3. This removes isRIPRel from X86ISelAddressMode, representing it with a basereg of RIP instead. 4. The addressing mode matching logic in isel is greatly simplified. 5. The asmprinter is greatly simplified, notably the "NotRIPRel" predicate passed through various printoperand routines is gone now. 6. The various symbol printing routines in asmprinter now no longer infer when to emit (%rip), they just print the symbol. I think this is a big improvement over the previous situation. It does have two small caveats though: 1. I implemented a horrible "no-rip" modifier for the inline asm "P" constraint modifier. This is a short term hack, there is a much better, but more involved, solution. 2. I had to xfail an -aggressive-remat testcase because it isn't handling the use of RIP in the constant-pool reading instruction. This specific test is easy to fix without -aggressive-remat, which I intend to do next. llvm-svn: 74372
Diffstat (limited to 'llvm/test')
-rw-r--r--llvm/test/CodeGen/X86/remat-constant.ll1
-rw-r--r--llvm/test/CodeGen/X86/tls3.ll2
2 files changed, 2 insertions, 1 deletions
diff --git a/llvm/test/CodeGen/X86/remat-constant.ll b/llvm/test/CodeGen/X86/remat-constant.ll
index 4c983b01488..1b70bf71938 100644
--- a/llvm/test/CodeGen/X86/remat-constant.ll
+++ b/llvm/test/CodeGen/X86/remat-constant.ll
@@ -1,4 +1,5 @@
; RUN: llvm-as < %s | llc -mtriple=x86_64-linux -relocation-model=static -aggressive-remat | grep xmm | count 2
+; XFAIL: *
declare void @bar() nounwind
diff --git a/llvm/test/CodeGen/X86/tls3.ll b/llvm/test/CodeGen/X86/tls3.ll
index e8d1a340baa..061849901fc 100644
--- a/llvm/test/CodeGen/X86/tls3.ll
+++ b/llvm/test/CodeGen/X86/tls3.ll
@@ -7,7 +7,7 @@
@i = external thread_local global i32 ; <i32*> [#uses=2]
-define i32 @f() {
+define i32 @f() nounwind {
entry:
%tmp1 = load i32* @i ; <i32> [#uses=1]
ret i32 %tmp1
OpenPOWER on IntegriCloud