diff options
| author | Toma Tabacu <toma.tabacu@imgtec.com> | 2015-04-27 14:05:04 +0000 |
|---|---|---|
| committer | Toma Tabacu <toma.tabacu@imgtec.com> | 2015-04-27 14:05:04 +0000 |
| commit | d9d344b48584727c2690cce89f320ad0a09f659c (patch) | |
| tree | 90d72005f1b76ffd61fc563a95e2544c3602af09 /llvm/test | |
| parent | 6bf4da02c13673bfd34f447a4b8a68905e05dea7 (diff) | |
| download | bcm5719-llvm-d9d344b48584727c2690cce89f320ad0a09f659c.tar.gz bcm5719-llvm-d9d344b48584727c2690cce89f320ad0a09f659c.zip | |
[mips] [IAS] Improve warning for using AT with .set noat.
Summary:
Changed the warning message to show the current value of $at, similar to what clang does for typedef's, and renamed warnIfAssemblerTemporary to a more descriptive name.
I also changed the type of variables which store registers from int to unsigned, updated the relevant test and tried to make the related comments clearer.
Reviewers: dsanders
Reviewed By: dsanders
Subscribers: llvm-commits
Differential Revision: http://reviews.llvm.org/D8479
llvm-svn: 235881
Diffstat (limited to 'llvm/test')
| -rw-r--r-- | llvm/test/MC/Mips/set-at-directive-explicit-at.s | 23 |
1 files changed, 12 insertions, 11 deletions
diff --git a/llvm/test/MC/Mips/set-at-directive-explicit-at.s b/llvm/test/MC/Mips/set-at-directive-explicit-at.s index 28a7091c8d2..d2d1c1d4627 100644 --- a/llvm/test/MC/Mips/set-at-directive-explicit-at.s +++ b/llvm/test/MC/Mips/set-at-directive-explicit-at.s @@ -1,32 +1,34 @@ # RUN: llvm-mc %s -triple=mipsel-unknown-linux -show-encoding -mcpu=mips32r2 \ # RUN: 2>%t1 | FileCheck %s # RUN: FileCheck -check-prefix=WARNINGS %s < %t1 -# Check that the assembler can handle the documented syntax -# for ".set at" and set the correct value. The correct value for $at is always -# $1 when written by the user. + +# Check that the assembler can handle the documented syntax for ".set at" and +# will set the correct value for $at. +# Note that writing $at is always the same as writing $1. + .text foo: # CHECK: jr $1 # encoding: [0x08,0x00,0x20,0x00] -# WARNINGS: :[[@LINE+2]]:11: warning: used $at without ".set noat" +# WARNINGS: :[[@LINE+2]]:11: warning: used $at (currently $1) without ".set noat" .set at=$1 jr $at # CHECK: jr $1 # encoding: [0x08,0x00,0x20,0x00] -# WARNINGS: :[[@LINE+2]]:11: warning: used $at without ".set noat" +# WARNINGS: :[[@LINE+2]]:11: warning: used $at (currently $1) without ".set noat" .set at=$1 jr $1 # CHECK: jr $1 # encoding: [0x08,0x00,0x20,0x00] -# WARNINGS: :[[@LINE+2]]:11: warning: used $at without ".set noat" +# WARNINGS: :[[@LINE+2]]:11: warning: used $at (currently $1) without ".set noat" .set at=$at jr $at # CHECK: jr $1 # encoding: [0x08,0x00,0x20,0x00] -# WARNINGS: :[[@LINE+2]]:11: warning: used $at without ".set noat" +# WARNINGS: :[[@LINE+2]]:11: warning: used $at (currently $1) without ".set noat" .set at=$at jr $1 -# WARNINGS-NOT: warning: used $at without ".set noat" +# WARNINGS-NOT: warning: used $at (currently ${{[0-9]+}}) without ".set noat" # CHECK: jr $1 # encoding: [0x08,0x00,0x20,0x00] .set at=$2 jr $at @@ -41,12 +43,11 @@ foo: jr $at # CHECK: jr $16 # encoding: [0x08,0x00,0x00,0x02] -# WARNINGS: :[[@LINE+2]]:11: warning: used $16 with ".set at=$16" +# WARNINGS: :[[@LINE+2]]:11: warning: used $at (currently $16) without ".set noat" .set at=$16 jr $s0 # CHECK: jr $16 # encoding: [0x08,0x00,0x00,0x02] -# WARNINGS: :[[@LINE+2]]:11: warning: used $16 with ".set at=$16" +# WARNINGS: :[[@LINE+2]]:11: warning: used $at (currently $16) without ".set noat" .set at=$16 jr $16 -# WARNINGS-NOT: warning |
