diff options
| author | Ahmed Bougacha <ahmed.bougacha@gmail.com> | 2015-05-11 23:09:46 +0000 |
|---|---|---|
| committer | Ahmed Bougacha <ahmed.bougacha@gmail.com> | 2015-05-11 23:09:46 +0000 |
| commit | b61696656eb850d139572dae75bcc4c2f0bed9f8 (patch) | |
| tree | c8c18625c24b92d726ccd9b9fdcaf1f94452fdc4 /llvm/test | |
| parent | 96b481959f3c009ea6e11b38d48c876c0f0436f5 (diff) | |
| download | bcm5719-llvm-b61696656eb850d139572dae75bcc4c2f0bed9f8.tar.gz bcm5719-llvm-b61696656eb850d139572dae75bcc4c2f0bed9f8.zip | |
[MemCpyOpt] Look at any dependency -not just source- for memset+memcpy.
This fixes another miscompile introduced by r235232: when there was a
dependency on the memcpy destination other than the memset, we would
ignore it, because we only looked at the source dependency.
It was a mistake to use SrcDepInfo. Instead, just use DepInfo.
llvm-svn: 237066
Diffstat (limited to 'llvm/test')
| -rw-r--r-- | llvm/test/Transforms/MemCpyOpt/memset-memcpy-redundant-memset.ll | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/llvm/test/Transforms/MemCpyOpt/memset-memcpy-redundant-memset.ll b/llvm/test/Transforms/MemCpyOpt/memset-memcpy-redundant-memset.ll index 0a21e71b21b..d0ec1dde828 100644 --- a/llvm/test/Transforms/MemCpyOpt/memset-memcpy-redundant-memset.ll +++ b/llvm/test/Transforms/MemCpyOpt/memset-memcpy-redundant-memset.ll @@ -126,6 +126,24 @@ define void @test_different_dst(i8* %dst2, i8* %src, i64 %src_size, i8* %dst, i6 ret void } +; Make sure we also take into account dependencies on the destination. + +; CHECK-LABEL: define i8 @test_intermediate_read +; CHECK-NEXT: %ca = alloca [64 x i8], align 8 +; CHECK-NEXT: %c = getelementptr [64 x i8], [64 x i8]* %ca, i64 0, i64 0 +; CHECK-NEXT: call void @llvm.memset.p0i8.i64(i8* %a, i8 0, i64 64, i32 1, i1 false) +; CHECK-NEXT: %r = load i8, i8* %a +; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i64(i8* %a, i8* %b, i64 24, i32 1, i1 false) +; CHECK-NEXT: ret i8 %r +define i8 @test_intermediate_read(i8* %a, i8* %b) #0 { + %ca = alloca [64 x i8], align 8 + %c = getelementptr [64 x i8], [64 x i8]* %ca, i64 0, i64 0 + call void @llvm.memset.p0i8.i64(i8* %a, i8 0, i64 64, i32 1, i1 false) + %r = load i8, i8* %a + call void @llvm.memcpy.p0i8.p0i8.i64(i8* %a, i8* %b, i64 24, i32 1, i1 false) + ret i8 %r +} + declare void @llvm.memset.p0i8.i64(i8* nocapture, i8, i64, i32, i1) declare void @llvm.memcpy.p0i8.p0i8.i64(i8* nocapture, i8* nocapture readonly, i64, i32, i1) declare void @llvm.memset.p0i8.i32(i8* nocapture, i8, i32, i32, i1) |
