diff options
| author | Nico Weber <nicolasweber@gmx.de> | 2016-01-06 19:05:19 +0000 |
|---|---|---|
| committer | Nico Weber <nicolasweber@gmx.de> | 2016-01-06 19:05:19 +0000 |
| commit | 891419adc276e70861a59c0f13084b743dd90e76 (patch) | |
| tree | 27dd6f399f10512098b55625f2108306f40718d7 /llvm/test | |
| parent | ab69e9f497404abc21f8a7d47918002a8b777531 (diff) | |
| download | bcm5719-llvm-891419adc276e70861a59c0f13084b743dd90e76.tar.gz bcm5719-llvm-891419adc276e70861a59c0f13084b743dd90e76.zip | |
Make WinCOFFObjectWriter.cpp's timestamp writing not use ENABLE_TIMESTAMPS
LLVM_ENABLE_TIMESTAMPS controls if timestamps are embedded into llvm's
binaries. Turning it off is useful for deterministic builds.
r246905 made it so that the define suddenly also controls if the binaries that
the llvm binaries _create_ embed timestamps or not – but this shouldn't be a
configure-time option. r256203/r256204 added a driver option to toggle this on
and off, so this patch now passes this driver option in LLVM_ENABLE_TIMESTAMPS
builds so that if LLVM_ENABLE_TIMESTAMPS is set, the build of LLVM is
deterministic – but the built clang can still write timestamps into other
executables when requested.
This also allows removing some of the test machinery added in r292012 to work
around this problem.
See PR24740 for background.
http://reviews.llvm.org/D15783
llvm-svn: 256958
Diffstat (limited to 'llvm/test')
| -rw-r--r-- | llvm/test/MC/COFF/timestamp.s | 1 | ||||
| -rw-r--r-- | llvm/test/lit.cfg | 4 | ||||
| -rw-r--r-- | llvm/test/lit.site.cfg.in | 1 |
3 files changed, 0 insertions, 6 deletions
diff --git a/llvm/test/MC/COFF/timestamp.s b/llvm/test/MC/COFF/timestamp.s index a2761575789..140225acf7e 100644 --- a/llvm/test/MC/COFF/timestamp.s +++ b/llvm/test/MC/COFF/timestamp.s @@ -1,5 +1,4 @@ // RUN: llvm-mc -filetype=obj -triple i686-pc-win32 -incremental-linker-compatible %s -o - | llvm-readobj -h | FileCheck %s -// REQUIRES: timestamps // CHECK: ImageFileHeader { // CHECK: TimeDateStamp: diff --git a/llvm/test/lit.cfg b/llvm/test/lit.cfg index 36b4c704408..5cc4d6e0456 100644 --- a/llvm/test/lit.cfg +++ b/llvm/test/lit.cfg @@ -459,10 +459,6 @@ if platform.system() in ['Windows'] and re.match(r'.*-win32$', config.target_tri if not re.match(r'^x86_64.*-(mingw32|windows-gnu|win32)', config.target_triple): config.available_features.add('debug_frame') -# Check if we are embedding timestamps. -if config.enable_timestamps == '1': - config.available_features.add('timestamps') - # Check if we should use gmalloc. use_gmalloc_str = lit_config.params.get('use_gmalloc', None) if use_gmalloc_str is not None: diff --git a/llvm/test/lit.site.cfg.in b/llvm/test/lit.site.cfg.in index ae5814f02f4..13f5372ef7e 100644 --- a/llvm/test/lit.site.cfg.in +++ b/llvm/test/lit.site.cfg.in @@ -36,7 +36,6 @@ config.llvm_use_sanitizer = "@LLVM_USE_SANITIZER@" config.have_zlib = "@HAVE_LIBZ@" config.have_dia_sdk = @HAVE_DIA_SDK@ config.enable_ffi = "@LLVM_ENABLE_FFI@" -config.enable_timestamps = "@ENABLE_TIMESTAMPS@" config.test_examples = "@ENABLE_EXAMPLES@" # Support substitution of the tools_dir with user parameters. This is |
