diff options
| author | Jonas Devlieghere <jonas@devlieghere.com> | 2018-07-29 14:56:15 +0000 |
|---|---|---|
| committer | Jonas Devlieghere <jonas@devlieghere.com> | 2018-07-29 14:56:15 +0000 |
| commit | ae1727e3ddf100a20f0c760c57fe8866756ea494 (patch) | |
| tree | f996c3eb783307b68d371dc8849b39b60adab3ae /llvm/test/tools | |
| parent | f52eeb11237af5bda4516668d3ee1784fd3b16c5 (diff) | |
| download | bcm5719-llvm-ae1727e3ddf100a20f0c760c57fe8866756ea494.tar.gz bcm5719-llvm-ae1727e3ddf100a20f0c760c57fe8866756ea494.zip | |
[dsymutil] Simplify temporary file handling.
Dsymutil's update functionality was broken on Windows because we tried
to rename a file while we're holding open handles to that file. TempFile
provides a solution for this through its keep(Twine) method. This patch
changes dsymutil to make use of that functionality.
Differential revision: https://reviews.llvm.org/D49860
llvm-svn: 338216
Diffstat (limited to 'llvm/test/tools')
| -rw-r--r-- | llvm/test/tools/dsymutil/X86/accelerator.test | 4 | ||||
| -rw-r--r-- | llvm/test/tools/dsymutil/X86/update-one-CU.test | 4 | ||||
| -rw-r--r-- | llvm/test/tools/dsymutil/X86/update.test | 4 |
3 files changed, 0 insertions, 12 deletions
diff --git a/llvm/test/tools/dsymutil/X86/accelerator.test b/llvm/test/tools/dsymutil/X86/accelerator.test index 906b0e645cf..96fc58ee568 100644 --- a/llvm/test/tools/dsymutil/X86/accelerator.test +++ b/llvm/test/tools/dsymutil/X86/accelerator.test @@ -1,7 +1,3 @@ -UNSUPPORTED: system-windows -Windows does not like renaming files that have open handles to them. We -need to use TempFile::keep to move them in a portable way. - RUN: dsymutil -accelerator=Dwarf -oso-prepend-path=%p/.. %p/../Inputs/basic.macho.x86_64 -o %t.dwarf.dSYM RUN: dsymutil -accelerator=Apple -oso-prepend-path=%p/.. %p/../Inputs/basic.macho.x86_64 -o %t.apple.dSYM diff --git a/llvm/test/tools/dsymutil/X86/update-one-CU.test b/llvm/test/tools/dsymutil/X86/update-one-CU.test index 5d36ce7135f..09f49ca89c4 100644 --- a/llvm/test/tools/dsymutil/X86/update-one-CU.test +++ b/llvm/test/tools/dsymutil/X86/update-one-CU.test @@ -1,7 +1,3 @@ -UNSUPPORTED: system-windows -Windows does not like renaming files that have open handles to them. We -need to use TempFile::keep to move them in a portable way. - RUN: dsymutil -oso-prepend-path=%p/.. %p/../Inputs/objc.macho.x86_64 -o %t.dSYM RUN: dsymutil -update %t.dSYM RUN: llvm-dwarfdump -apple-types -apple-objc %t.dSYM | FileCheck %s diff --git a/llvm/test/tools/dsymutil/X86/update.test b/llvm/test/tools/dsymutil/X86/update.test index cbfff63d6a8..804091ab294 100644 --- a/llvm/test/tools/dsymutil/X86/update.test +++ b/llvm/test/tools/dsymutil/X86/update.test @@ -1,7 +1,3 @@ -UNSUPPORTED: system-windows -Windows does not like renaming files that have open handles to them. We -need to use TempFile::keep to move them in a portable way. - RUN: rm -rf %t.dir RUN: mkdir -p %t.dir RUN: cat %p/../Inputs/basic.macho.x86_64 > %t.dir/basic |
