diff options
| author | George Rimar <grimar@accesssoftek.com> | 2019-08-17 14:36:40 +0000 |
|---|---|---|
| committer | George Rimar <grimar@accesssoftek.com> | 2019-08-17 14:36:40 +0000 |
| commit | bb56755f153a83387fa6c7fa0a6d7d540da41633 (patch) | |
| tree | fbff5a5ba4e67a2af5bca0cf4018a59eeafb6af7 /llvm/test/tools/llvm-readobj/elf-non-dynamic-in-pt-dynamic.test | |
| parent | 50166f81072c8aba7690b0a57e751393732b64e8 (diff) | |
| download | bcm5719-llvm-bb56755f153a83387fa6c7fa0a6d7d540da41633.tar.gz bcm5719-llvm-bb56755f153a83387fa6c7fa0a6d7d540da41633.zip | |
[llvm-readobj/llvm-readelf] - Improve/cleanup the error reporting API.
urrently we have the following functions for error reporting:
--
LLVM_ATTRIBUTE_NORETURN void reportError(Twine Msg);
void reportError(Error Err, StringRef Input);
void reportWarning(Twine Msg);
void reportWarning(StringRef Input, Error Err);
void warn(llvm::Error Err);
void error(std::error_code EC);
---
Problems are: naming is inconsistent, arguments order is inconsistent,
some of the functions looks excessive.
After applying this patch we have:
---
LLVM_ATTRIBUTE_NORETURN void reportError(Error Err, StringRef Input);
LLVM_ATTRIBUTE_NORETURN void reportError(std::error_code EC, StringRef Input);
void reportWarning(Error Err, StringRef Input);
---
I'd be happy to remove reportError(std::error_code EC, StringRef Input) too, but it
is used by COFF heavily.
Test cases were updated, they show an improvement introduced.
Differential revision: https://reviews.llvm.org/D66286
llvm-svn: 369190
Diffstat (limited to 'llvm/test/tools/llvm-readobj/elf-non-dynamic-in-pt-dynamic.test')
| -rw-r--r-- | llvm/test/tools/llvm-readobj/elf-non-dynamic-in-pt-dynamic.test | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/llvm/test/tools/llvm-readobj/elf-non-dynamic-in-pt-dynamic.test b/llvm/test/tools/llvm-readobj/elf-non-dynamic-in-pt-dynamic.test index 37c4ad538a4..08bae9467af 100644 --- a/llvm/test/tools/llvm-readobj/elf-non-dynamic-in-pt-dynamic.test +++ b/llvm/test/tools/llvm-readobj/elf-non-dynamic-in-pt-dynamic.test @@ -6,11 +6,11 @@ # RUN: yaml2obj --docnum=1 %s -o %t.o # RUN: llvm-readobj --dynamic-table %t.o 2>&1 \ -# RUN: | FileCheck %s --check-prefixes=WARNING,LLVM +# RUN: | FileCheck %s --DFILE=%t.o --check-prefixes=WARNING,LLVM # RUN: llvm-readelf --dynamic-table %t.o 2>&1 \ -# RUN: | FileCheck %s --check-prefixes=WARNING,GNU +# RUN: | FileCheck %s --DFILE=%t.o --check-prefixes=WARNING,GNU -# WARNING: warning: The SHT_DYNAMIC section '.dynamic' is not at the start of PT_DYNAMIC segment +# WARNING: warning: '[[FILE]]': The SHT_DYNAMIC section '.dynamic' is not at the start of PT_DYNAMIC segment # LLVM: DynamicSection [ (2 entries) # LLVM-NEXT: Tag Type Name/Value |
