diff options
| author | Jordan Rupprecht <rupprecht@google.com> | 2019-10-17 21:55:43 +0000 |
|---|---|---|
| committer | Jordan Rupprecht <rupprecht@google.com> | 2019-10-17 21:55:43 +0000 |
| commit | 98a2ae7dadf897305e1cc2d9a5d63edf925c07f7 (patch) | |
| tree | e54cb59d119529e95bea30ef851486739d494727 /llvm/test/tools/llvm-objdump | |
| parent | 6caada4eb4654783a45f6ae7bb1cd0eebcf4b0bb (diff) | |
| download | bcm5719-llvm-98a2ae7dadf897305e1cc2d9a5d63edf925c07f7.tar.gz bcm5719-llvm-98a2ae7dadf897305e1cc2d9a5d63edf925c07f7.zip | |
Reland [llvm-objdump] Use a counter for llvm-objdump -h instead of the section index.
This relands r374931 (reverted in r375088). It fixes 32-bit builds by using the right format string specifier for uint64_t (PRIu64) instead of `%d`.
Original description:
When listing the index in `llvm-objdump -h`, use a zero-based counter instead of the actual section index (e.g. shdr->sh_index for ELF).
While this is effectively a noop for now (except one unit test for XCOFF), the index values will change in a future patch that filters certain sections out (e.g. symbol tables). See D68669 for more context. Note: the test case in `test/tools/llvm-objdump/X86/section-index.s` already covers the case of incrementing the section index counter when sections are skipped.
Reviewers: grimar, jhenderson, espindola
Reviewed By: grimar
Subscribers: emaste, sbc100, arichardson, aheejin, arphaman, seiya, llvm-commits, MaskRay
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D68848
llvm-svn: 375178
Diffstat (limited to 'llvm/test/tools/llvm-objdump')
| -rw-r--r-- | llvm/test/tools/llvm-objdump/xcoff-section-headers.test | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/llvm/test/tools/llvm-objdump/xcoff-section-headers.test b/llvm/test/tools/llvm-objdump/xcoff-section-headers.test index b5b5fe5a815..95d6f5baa3d 100644 --- a/llvm/test/tools/llvm-objdump/xcoff-section-headers.test +++ b/llvm/test/tools/llvm-objdump/xcoff-section-headers.test @@ -13,11 +13,11 @@ # CHECK: xcoff-section-headers.o: file format aixcoff-rs6000 # CHECK: Sections: # CHECK: Idx Name Size VMA Type -# CHECK: 1 .text 00000080 00000000 TEXT -# CHECK: 2 .data 00000024 00000080 DATA -# CHECK: 3 .bss 00000004 000000a4 BSS -# CHECK: 4 .tdata 00000008 00000000 DATA -# CHECK: 5 .tbss 00000004 00000008 BSS +# CHECK: 0 .text 00000080 00000000 TEXT +# CHECK: 1 .data 00000024 00000080 DATA +# CHECK: 2 .bss 00000004 000000a4 BSS +# CHECK: 3 .tdata 00000008 00000000 DATA +# CHECK: 4 .tbss 00000004 00000008 BSS # xcoff-section-headers.o Compiled with IBM XL C/C++ for AIX, V16.1.0 # test.c: @@ -32,10 +32,10 @@ # LONG: xcoff-long-sec-names.o: file format aixcoff-rs6000 # LONG: Sections: -# LONG: Idx Name Size VMA Type -# LONG: 1 .dwarnge 00000004 00000000 -# LONG: 2 .dwpbnms 00000004 00000000 -# LONG: 3 .dwpbtyp 00000004 00000000 +# LONG: Idx Name Size VMA Type +# LONG: 0 .dwarnge 00000004 00000000 +# LONG: 1 .dwpbnms 00000004 00000000 +# LONG: 2 .dwpbtyp 00000004 00000000 # xcoff-long-sec-names.o was generated by assembling the following .s file: # .dwsect 0x30000 # .dwpbnms section |
