diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2015-05-22 15:43:00 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2015-05-22 15:43:00 +0000 |
| commit | 62a07cb59b432f9539eb2bb34b9a1c5e44016b7c (patch) | |
| tree | da49ad104c5e37c7a9c6d19f50d4dbc886f26e10 /llvm/test/tools/llvm-objdump | |
| parent | f692ef9e472e40b7d7d38ddf4acec3914bf92440 (diff) | |
| download | bcm5719-llvm-62a07cb59b432f9539eb2bb34b9a1c5e44016b7c.tar.gz bcm5719-llvm-62a07cb59b432f9539eb2bb34b9a1c5e44016b7c.zip | |
Stop inventing symbol sizes.
MachO and COFF quite reasonably only define the size for common symbols.
We used to try to figure out the "size" by computing the gap from one symbol to
the next.
This would not be correct in general, since a part of a section can belong to no
visible symbol (padding, private globals).
It was also really expensive, since we would walk every symbol to find the size
of one.
If a caller really wants this, it can sort all the symbols once and get all the
gaps ("size") in O(n log n) instead of O(n^2).
On MachO this also has the advantage of centralizing all the checks for an
invalid n_sect.
llvm-svn: 238028
Diffstat (limited to 'llvm/test/tools/llvm-objdump')
| -rw-r--r-- | llvm/test/tools/llvm-objdump/X86/macho-symbol-table.test | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/llvm/test/tools/llvm-objdump/X86/macho-symbol-table.test b/llvm/test/tools/llvm-objdump/X86/macho-symbol-table.test index 5b9a4f84976..3fe5aea6c37 100644 --- a/llvm/test/tools/llvm-objdump/X86/macho-symbol-table.test +++ b/llvm/test/tools/llvm-objdump/X86/macho-symbol-table.test @@ -1,8 +1,8 @@ RUN: llvm-objdump -macho -t %p/Inputs/hello.obj.macho-x86_64 | FileCheck %s CHECK: SYMBOL TABLE: -CHECK: 000000000000003b l F __TEXT,__cstring 0000000d L_.str -CHECK: 0000000000000068 l F __TEXT,__eh_frame 00000018 EH_frame0 -CHECK: 0000000000000000 g F __TEXT,__text 0000003b _main -CHECK: 0000000000000080 g F __TEXT,__eh_frame 00000028 _main.eh +CHECK: 000000000000003b l F __TEXT,__cstring 00000000 L_.str +CHECK: 0000000000000068 l F __TEXT,__eh_frame 00000000 EH_frame0 +CHECK: 0000000000000000 g F __TEXT,__text 00000000 _main +CHECK: 0000000000000080 g F __TEXT,__eh_frame 00000000 _main.eh CHECK: 0000000000000000 *UND* 00000000 _printf |
