The next step along the way to getting good error messages for bad archives.

As mentioned in commit log for r276686 this next step is adding a new
method in the ArchiveMemberHeader class to get the full name that
does proper error checking, and can be use for error messages.

To do this the name of ArchiveMemberHeader::getName() is changed to
ArchiveMemberHeader::getRawName() to be consistent with
Archive::Child::getRawName().  Then the “new” method is the addition
of a new implementation of ArchiveMemberHeader::getName() which gets
the full name and provides proper error checking.  Which is mostly a rewrite
of what was Archive::Child::getName() and cleaning up incorrect uses of
llvm_unreachable() in the code which were actually just cases of errors
in the input Archives.

Then Archive::Child::getName() is changed to return Expected<> and use
the new implementation of ArchiveMemberHeader::getName() .

Also needed to change Archive::getMemoryBufferRef() with these
changes to return Expected<> as well to propagate Errors up.
As well as changing Archive::isThinMember() to return Expected<> .

llvm-svn: 277177

1 files changed, 13 insertions, 0 deletions

diff --git a/llvm/test/tools/llvm-objdump/Inputs/libbogus8.a b/llvm/test/tools/llvm-objdump/Inputs/libbogus8.a
new file mode 100644
index 00000000000..070c770846b
--- /dev/null
+++ b/llvm/test/tools/llvm-objdump/Inputs/libbogus8.a
@@ -0,0 +1,13 @@
+!<arch>
+foo.c           1444941645  124   0     100644  17        `
+void foo(void){}
+
+#1/1234         1469564779  124   0     100644  126       `
+1234567890123456Xhello.c#include <stdio.h>
+#include <stdlib.h>
+int
+main()
+{
+	printf("Hello World\n");
+	return EXIT_SUCCESS;
+}