InstrProf: Do a better job of reading coverage mapping data.

This code was casting regions of a memory buffer to a couple of
different structs. This is wrong in a few ways:

1. It breaks aliasing rules.
2. If the buffer isn't aligned, it hits undefined behaviour.
3. It completely ignores endianness differences.
4. The structs being defined for this aren't specifying their padding
   properly, so this doesn't even represent the data properly on some
   platforms.

This commit is mostly NFC, except that it fixes reading coverage for
32 bit binaries as a side effect of getting rid of the mispadded
structs. I've included a test for that.

I've also baked in that we only handle little endian more explicitly,
since that was true in practice already. I'll fix this to handle
endianness properly in a followup commit.

llvm-svn: 232346

1 files changed, 0 insertions, 0 deletions

diff --git a/llvm/test/tools/llvm-cov/Inputs/binary-formats.macho64l b/llvm/test/tools/llvm-cov/Inputs/binary-formats.macho64l
new file mode 100755
index 00000000000..0045c435575
--- /dev/null
+++ b/llvm/test/tools/llvm-cov/Inputs/binary-formats.macho64l