diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2018-01-11 22:15:05 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2018-01-11 22:15:05 +0000 |
| commit | e4b0231c63d40408d06ff4c3669ded4b4ecaaa85 (patch) | |
| tree | 9e89f032c39da53ab74bd3d38a87264e2b5ceaa4 /llvm/test/tools/gold/X86/global_with_section.ll | |
| parent | e97654b2f28072ad9123006c05e03efd82852982 (diff) | |
| download | bcm5719-llvm-e4b0231c63d40408d06ff4c3669ded4b4ecaaa85.tar.gz bcm5719-llvm-e4b0231c63d40408d06ff4c3669ded4b4ecaaa85.zip | |
Make internal/private GVs implicitly dso_local.
While updating clang tests for having clang set dso_local I noticed
that:
- There are *a lot* of tests to update.
- Many of the updates are redundant.
They are redundant because a GV is "obviously dso_local". This patch
starts formalizing that a bit by requiring that internal and private
GVs be dso_local too. Since they all are, we don't have to print
dso_local to the textual representation, making it a bit more compact
and easier to read.
llvm-svn: 322317
Diffstat (limited to 'llvm/test/tools/gold/X86/global_with_section.ll')
| -rw-r--r-- | llvm/test/tools/gold/X86/global_with_section.ll | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/llvm/test/tools/gold/X86/global_with_section.ll b/llvm/test/tools/gold/X86/global_with_section.ll index 75e2a6978b2..d2b7097d812 100644 --- a/llvm/test/tools/gold/X86/global_with_section.ll +++ b/llvm/test/tools/gold/X86/global_with_section.ll @@ -45,7 +45,7 @@ target triple = "x86_64-unknown-linux-gnu" ; Confirm via a variable with a non-C identifier section that we are getting ; the expected internalization. -; CHECK-DAG: @var_with_nonC_section = internal dso_local global i32 0, section ".nonCsection" +; CHECK-DAG: @var_with_nonC_section = internal global i32 0, section ".nonCsection" @var_with_nonC_section = global i32 0, section ".nonCsection" ; We should not internalize @deadfunc_with_section due to section @@ -57,7 +57,7 @@ define void @deadfunc_with_section() section "some_other_section" { ; Confirm via a function with a non-C identifier section that we are getting ; the expected internalization. -; CHECK-DAG: define internal dso_local void @deadfunc_with_nonC_section() section ".nonCsection" +; CHECK-DAG: define internal void @deadfunc_with_nonC_section() section ".nonCsection" define void @deadfunc_with_nonC_section() section ".nonCsection" { call void @deadfunc2_called_from_nonC_section() ret void @@ -65,7 +65,7 @@ define void @deadfunc_with_nonC_section() section ".nonCsection" { ; In RegularLTO mode, where we have combined all the IR, ; @deadfunc2_called_from_section can be internalized. -; CHECK2-REGULARLTO: define internal dso_local void @deadfunc2_called_from_section +; CHECK2-REGULARLTO: define internal void @deadfunc2_called_from_section ; In ThinLTO mode, we can't internalize it as it needs to be preserved ; (due to the access from @deadfunc_with_section which must be preserved), and ; can't be internalized since the reference is from a different module. @@ -74,6 +74,6 @@ declare void @deadfunc2_called_from_section() ; Confirm when called from a function with a non-C identifier section that we ; are getting the expected internalization. -; CHECK2-REGULARLTO: define internal dso_local void @deadfunc2_called_from_nonC_section -; CHECK2-THINLTO: define internal dso_local void @deadfunc2_called_from_nonC_section +; CHECK2-REGULARLTO: define internal void @deadfunc2_called_from_nonC_section +; CHECK2-THINLTO: define internal void @deadfunc2_called_from_nonC_section declare void @deadfunc2_called_from_nonC_section() |

