diff options
| author | Fangrui Song <maskray@google.com> | 2019-05-15 02:35:32 +0000 |
|---|---|---|
| committer | Fangrui Song <maskray@google.com> | 2019-05-15 02:35:32 +0000 |
| commit | f4dfd63c74899e2953b176de2174ae7a8924a72c (patch) | |
| tree | 10b8dd0ca599015981cbea658f927847791c4d5b /llvm/test/Verifier | |
| parent | bd3adfe5e3bcb6f8f16166d1fd8a3f3c4fd70307 (diff) | |
| download | bcm5719-llvm-f4dfd63c74899e2953b176de2174ae7a8924a72c.tar.gz bcm5719-llvm-f4dfd63c74899e2953b176de2174ae7a8924a72c.zip | |
[IR] Disallow llvm.global_ctors and llvm.global_dtors of the 2-field form in textual format
The 3-field form was introduced by D3499 in 2014 and the legacy 2-field
form was planned to be removed in LLVM 4.0
For the textual format, this patch migrates the existing 2-field form to
use the 3-field form and deletes the compatibility code.
test/Verifier/global-ctors-2.ll checks we have a friendly error message.
For bitcode, lib/IR/AutoUpgrade UpgradeGlobalVariables will upgrade the
2-field form (add i8* null as the third field).
Reviewed By: rnk, dexonsmith
Differential Revision: https://reviews.llvm.org/D61547
llvm-svn: 360742
Diffstat (limited to 'llvm/test/Verifier')
| -rw-r--r-- | llvm/test/Verifier/global-ctors-2.ll | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/llvm/test/Verifier/global-ctors-2.ll b/llvm/test/Verifier/global-ctors-2.ll new file mode 100644 index 00000000000..a811512a931 --- /dev/null +++ b/llvm/test/Verifier/global-ctors-2.ll @@ -0,0 +1,6 @@ +; RUN: not llvm-as %s -o /dev/null 2>&1 | FileCheck %s + +@llvm.global_ctors = appending global [1 x { i32, void()* } ] [ + { i32, void()* } { i32 65535, void ()* null } +] +; CHECK: the third field of the element type is mandatory, specify i8* null to migrate from the obsoleted 2-field form |
