diff options
| author | Wei Mi <wmi@google.com> | 2015-04-21 23:02:15 +0000 |
|---|---|---|
| committer | Wei Mi <wmi@google.com> | 2015-04-21 23:02:15 +0000 |
| commit | a0adf9fd41deedda6ba5f5b19c11d30fe0282450 (patch) | |
| tree | 6a7186dac047bd5f92acfe249df716c60e6b8514 /llvm/test/Transforms | |
| parent | 6598431c7acadcf0f3dedd6853163209c14a2cc7 (diff) | |
| download | bcm5719-llvm-a0adf9fd41deedda6ba5f5b19c11d30fe0282450.tar.gz bcm5719-llvm-a0adf9fd41deedda6ba5f5b19c11d30fe0282450.zip | |
Limiting gep merging to fix the performance problem described in
https://llvm.org/bugs/show_bug.cgi?id=23163.
Gep merging sometimes behaves like a reverse CSE/LICM optimization,
which has negative impact on performance. In this patch we restrict
gep merging to happen only when the indexes to be merged are both consts,
which ensures such merge is always beneficial.
The patch makes gep merging only happen in very restrictive cases.
It is possible that some analysis/optimization passes rely on the merged
geps to get better result, and we havn't notice them yet. We will be ready
to further improve it once we see the cases.
Differential Revision: http://reviews.llvm.org/D8911
llvm-svn: 235455
Diffstat (limited to 'llvm/test/Transforms')
| -rw-r--r-- | llvm/test/Transforms/InstCombine/descale-zero.ll | 20 | ||||
| -rw-r--r-- | llvm/test/Transforms/InstCombine/getelementptr.ll | 4 |
2 files changed, 2 insertions, 22 deletions
diff --git a/llvm/test/Transforms/InstCombine/descale-zero.ll b/llvm/test/Transforms/InstCombine/descale-zero.ll index 4347be48e61..e69de29bb2d 100644 --- a/llvm/test/Transforms/InstCombine/descale-zero.ll +++ b/llvm/test/Transforms/InstCombine/descale-zero.ll @@ -1,20 +0,0 @@ -; RUN: opt < %s -instcombine -S | FileCheck %s - -target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128" -target triple = "x86_64-apple-macosx10.10.0" - -define internal i8* @descale_zero() { -entry: -; CHECK: load i8*, i8** inttoptr (i64 48 to i8**), align 16 -; CHECK-NEXT: ret i8* - %i16_ptr = load i16*, i16** inttoptr (i64 48 to i16**), align 16 - %num = load i64, i64* inttoptr (i64 64 to i64*), align 64 - %num_times_2 = shl i64 %num, 1 - %num_times_2_plus_4 = add i64 %num_times_2, 4 - %i8_ptr = bitcast i16* %i16_ptr to i8* - %i8_ptr_num_times_2_plus_4 = getelementptr i8, i8* %i8_ptr, i64 %num_times_2_plus_4 - %num_times_neg2 = mul i64 %num, -2 - %num_times_neg2_minus_4 = add i64 %num_times_neg2, -4 - %addr = getelementptr i8, i8* %i8_ptr_num_times_2_plus_4, i64 %num_times_neg2_minus_4 - ret i8* %addr -} diff --git a/llvm/test/Transforms/InstCombine/getelementptr.ll b/llvm/test/Transforms/InstCombine/getelementptr.ll index 9bb1b12a697..276ada91f3c 100644 --- a/llvm/test/Transforms/InstCombine/getelementptr.ll +++ b/llvm/test/Transforms/InstCombine/getelementptr.ll @@ -104,8 +104,8 @@ define i32* @test7(i32* %I, i64 %C, i64 %D) { %B = getelementptr i32, i32* %A, i64 %D ret i32* %B ; CHECK-LABEL: @test7( -; CHECK: %A.sum = add i64 %C, %D -; CHECK: getelementptr i32, i32* %I, i64 %A.sum +; CHECK: %A = getelementptr i32, i32* %I, i64 %C +; CHECK: %B = getelementptr i32, i32* %A, i64 %D } define i8* @test8([10 x i32]* %X) { |
