diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2015-05-22 15:43:00 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2015-05-22 15:43:00 +0000 |
| commit | 62a07cb59b432f9539eb2bb34b9a1c5e44016b7c (patch) | |
| tree | da49ad104c5e37c7a9c6d19f50d4dbc886f26e10 /llvm/test/Object/macho-invalid.test | |
| parent | f692ef9e472e40b7d7d38ddf4acec3914bf92440 (diff) | |
| download | bcm5719-llvm-62a07cb59b432f9539eb2bb34b9a1c5e44016b7c.tar.gz bcm5719-llvm-62a07cb59b432f9539eb2bb34b9a1c5e44016b7c.zip | |
Stop inventing symbol sizes.
MachO and COFF quite reasonably only define the size for common symbols.
We used to try to figure out the "size" by computing the gap from one symbol to
the next.
This would not be correct in general, since a part of a section can belong to no
visible symbol (padding, private globals).
It was also really expensive, since we would walk every symbol to find the size
of one.
If a caller really wants this, it can sort all the symbols once and get all the
gaps ("size") in O(n log n) instead of O(n^2).
On MachO this also has the advantage of centralizing all the checks for an
invalid n_sect.
llvm-svn: 238028
Diffstat (limited to 'llvm/test/Object/macho-invalid.test')
| -rw-r--r-- | llvm/test/Object/macho-invalid.test | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/llvm/test/Object/macho-invalid.test b/llvm/test/Object/macho-invalid.test index dae5c4eda7e..e2c9b6b7360 100644 --- a/llvm/test/Object/macho-invalid.test +++ b/llvm/test/Object/macho-invalid.test @@ -28,13 +28,6 @@ RUN: | FileCheck -check-prefix NAME-PAST-EOF %s RUN: not llvm-nm %p/Inputs/macho-invalid-section-index-getSectionRawName 2>&1 \ RUN: | FileCheck -check-prefix INVALID-SECTION-IDX-SYMBOL-SEC %s -RUN: not llvm-objdump -t %p/Inputs/macho-invalid-getsection-index 2>&1 \ -RUN: | FileCheck -check-prefix INVALID-SECTION-IDX-GETSECT %s - -RUN: not llvm-objdump -t %p/Inputs/macho64-invalid-getsection-index 2>&1 \ -RUN: | FileCheck -check-prefix INVALID-SECTION-IDX-GETSECT64 %s - - SMALL-LOADC-SIZE: Load command with size < 8 bytes SMALL-SEGLOADC-SIZE: Segment load command size is too small INCOMPLETE-LOADC: Malformed MachO file @@ -43,5 +36,3 @@ BAD-SYMBOL: Requested symbol index is out of range NAME-PAST-EOF: Symbol name entry points before beginning or past end of file INVALID-SECTION-IDX-SYMBOL-SEC: getSymbolSection: Invalid section index -INVALID-SECTION-IDX-GETSECT: getSection: Invalid section index -INVALID-SECTION-IDX-GETSECT64: getSection64: Invalid section index |
