diff options
| author | Fangrui Song <maskray@google.com> | 2019-09-29 15:26:12 +0000 |
|---|---|---|
| committer | Fangrui Song <maskray@google.com> | 2019-09-29 15:26:12 +0000 |
| commit | c5133606627036df0275849ac3d140a86908e310 (patch) | |
| tree | 581aa9d8e22f2409945dc005d7405cdbbc7a6713 /llvm/test/MC | |
| parent | d30093bb8a3f12d35d176a85cf93e354a38ff116 (diff) | |
| download | bcm5719-llvm-c5133606627036df0275849ac3d140a86908e310.tar.gz bcm5719-llvm-c5133606627036df0275849ac3d140a86908e310.zip | |
[MC] Emit unused undefined symbol even if its binding is not set
For the following two cases, we currently suppress the symbols. This
patch emits them (compatible with GNU as).
* `test2_a = undef`: if `undef` is otherwise unused.
* `.hidden hidden`: if `hidden` is unused. This is the main point of the
patch, because omitting the symbol would cause a linker semantic
difference.
It causes a behavior change that is not compatible with GNU as:
.weakref foo1, bar1
When neither foo1 nor bar1 is used, we now emit bar1, which is arguably
more consistent.
Another change is that we will emit .TOC. for .TOC.@tocbase . For this
directive, suppressing .TOC. can be seen as a size optimization, but we
choose to drop it for simplicity and consistency.
llvm-svn: 373168
Diffstat (limited to 'llvm/test/MC')
| -rw-r--r-- | llvm/test/MC/ELF/undef.s | 22 | ||||
| -rw-r--r-- | llvm/test/MC/ELF/weakref.s | 9 |
2 files changed, 31 insertions, 0 deletions
diff --git a/llvm/test/MC/ELF/undef.s b/llvm/test/MC/ELF/undef.s index f313d71369e..9d99b834ffd 100644 --- a/llvm/test/MC/ELF/undef.s +++ b/llvm/test/MC/ELF/undef.s @@ -18,6 +18,8 @@ .text movsd .Lsym8(%rip), %xmm1 +.hidden hidden + test2_a = undef test2_b = undef + 1 @@ -41,6 +43,17 @@ test2_b = undef + 1 // CHECK-NEXT: Section: .rodata.str1.1 // CHECK-NEXT: } // CHECK-NEXT: Symbol { +// CHECK-NEXT: Name: hidden +// CHECK-NEXT: Value: 0x0 +// CHECK-NEXT: Size: 0 +// CHECK-NEXT: Binding: Global +// CHECK-NEXT: Type: None +// CHECK-NEXT: Other [ +// CHECK-NEXT: STV_HIDDEN +// CHECK-NEXT: ] +// CHECK-NEXT: Section: Undefined +// CHECK-NEXT: } +// CHECK-NEXT: Symbol { // CHECK-NEXT: Name: sym6 // CHECK-NEXT: Value: 0x0 // CHECK-NEXT: Size: 0 @@ -49,4 +62,13 @@ test2_b = undef + 1 // CHECK-NEXT: Other: 0 // CHECK-NEXT: Section: Undefined // CHECK-NEXT: } +// CHECK-NEXT: Symbol { +// CHECK-NEXT: Name: undef +// CHECK-NEXT: Value: 0x0 +// CHECK-NEXT: Size: 0 +// CHECK-NEXT: Binding: Global +// CHECK-NEXT: Type: None +// CHECK-NEXT: Other: 0 +// CHECK-NEXT: Section: Undefined +// CHECK-NEXT: } // CHECK-NEXT: ] diff --git a/llvm/test/MC/ELF/weakref.s b/llvm/test/MC/ELF/weakref.s index 51905d8ad7c..bca8ec4f281 100644 --- a/llvm/test/MC/ELF/weakref.s +++ b/llvm/test/MC/ELF/weakref.s @@ -125,6 +125,15 @@ bar15: // CHECK-NEXT: Section: .text // CHECK-NEXT: } // CHECK-NEXT: Symbol { +// CHECK-NEXT: Name: bar1 +// CHECK-NEXT: Value: 0x0 +// CHECK-NEXT: Size: 0 +// CHECK-NEXT: Binding: Global +// CHECK-NEXT: Type: None +// CHECK-NEXT: Other: 0 +// CHECK-NEXT: Section: Undefined +// CHECK-NEXT: } +// CHECK-NEXT: Symbol { // CHECK-NEXT: Name: bar10 // CHECK-NEXT: Value: 0x28 // CHECK-NEXT: Size: 0 |
