diff options
| author | James Molloy <james.molloy@arm.com> | 2017-05-22 09:42:07 +0000 |
|---|---|---|
| committer | James Molloy <james.molloy@arm.com> | 2017-05-22 09:42:07 +0000 |
| commit | 6110be9759f6accf215c793c31278d6d4849bf6f (patch) | |
| tree | 62ec6add4269987b3075d7c21e1f585f76e2314f /llvm/test/MC | |
| parent | 5193c80830995d951049db7bcf510e38b0b1521e (diff) | |
| download | bcm5719-llvm-6110be9759f6accf215c793c31278d6d4849bf6f.tar.gz bcm5719-llvm-6110be9759f6accf215c793c31278d6d4849bf6f.zip | |
Re-apply r302416: [ARM] Clear the constant pool cache on explicit .ltorg directives
Re-applying now that PR32825 which was raised on the commit this fixed up is now known to have also been fixed by this commit.
Original commit message:
Multiple ldr pseudoinstructions with the same constant value will
reuse the same constant pool entry. However, if the constant pool
is explicitly flushed with a .ltorg directive, we should not try
to reference constants in the previous pool any longer, since they
may be out of range.
This fixes assembling hand-written assembler source which repeatedly
loads the same constant value, across a binary size larger than the
pc-relative fixup range for ldr instructions (4096 bytes). Such
assembler source already uses explicit .ltorg instructions to emit
constant pools with regular intervals. However if we try to reuse
constants emitted in earlier pools, they end up out of range.
This makes the output of the testcase match what binutils gas does
(prior to this patch, it would fail to assemble).
Differential Revision: https://reviews.llvm.org/D32847
llvm-svn: 303540
Diffstat (limited to 'llvm/test/MC')
| -rw-r--r-- | llvm/test/MC/ARM/ltorg-range.s | 27 |
1 files changed, 27 insertions, 0 deletions
diff --git a/llvm/test/MC/ARM/ltorg-range.s b/llvm/test/MC/ARM/ltorg-range.s new file mode 100644 index 00000000000..5c27d4cd0df --- /dev/null +++ b/llvm/test/MC/ARM/ltorg-range.s @@ -0,0 +1,27 @@ +@ RUN: llvm-mc -triple armv7-unknown-linux-gnueabi -filetype obj -o - %s \ +@ RUN: | llvm-objdump -d - | FileCheck %s + + ldr r0, =0x01020304 +@ CHECK: ldr + .ltorg +@ CHECK: 0x01020304 + ldr r0, =0x01020304 + ldr r0, =0x01020304 + ldr r0, =0x01020304 +@ CHECK: ldr +@ CHECK: ldr +@ CHECK: ldr + .ltorg +@ CHECK: 0x01020304 + .rep 1028 + .word 0 + .endr +@ CHECK: 0x00000000 + + ldr r0, =0x01020304 +@ CHECK: ldr + .ltorg +@ CHECK: 0x01020304 + .rep 1028 + .word 0 + .endr |
