diff options
| author | David Blaikie <dblaikie@gmail.com> | 2014-10-23 22:27:50 +0000 |
|---|---|---|
| committer | David Blaikie <dblaikie@gmail.com> | 2014-10-23 22:27:50 +0000 |
| commit | 1dd573db45960e725a983a3843c34f61ebda1ac8 (patch) | |
| tree | 07e37cba8b49a35741857206c611c69e6b09367c /llvm/test/DebugInfo/varargs.ll | |
| parent | 56af52f85286b2d75788ef447d5c46aad747ab31 (diff) | |
| download | bcm5719-llvm-1dd573db45960e725a983a3843c34f61ebda1ac8.tar.gz bcm5719-llvm-1dd573db45960e725a983a3843c34f61ebda1ac8.zip | |
DebugInfo: Remove DwarfDebug::CurrentFnArguments since we have to handle argument ordering of other arguments (abstract arguments) in the same way and already have code for that too.
While refactoring this code I was confused by both the name I had
introduced (addNonArgumentVariable... but it has all this logic to
handle argument numbering and keep things in order?) and by the
redundancy. Seems when I fixed the misordered inlined argument handling,
I didn't realize it was mostly redundant with the argument ordering code
(which I may've also written, I'm not sure). So let's just rely on the
more general case.
The only oddity in output this produces is that it means when we emit
all the variables for the current function, we don't track when we've
finished the argument variables and are about to start the local
variables and insert DW_AT_unspecified_parameters (for varargs
functions) there. Instead it ends up after the local variables, scopes,
etc. But this isn't invalid and doesn't cause DWARF consumers problems
that I know of... so we'll just go with that because it makes the code
nice & simple.
(though, let's see what the buildbots have to say about this - *crosses
fingers*)
There will be some cleanup commits to follow to remove the now trivial
wrappers, etc.
llvm-svn: 220527
Diffstat (limited to 'llvm/test/DebugInfo/varargs.ll')
| -rw-r--r-- | llvm/test/DebugInfo/varargs.ll | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/llvm/test/DebugInfo/varargs.ll b/llvm/test/DebugInfo/varargs.ll index 5f64030acac..1fe598a76a3 100644 --- a/llvm/test/DebugInfo/varargs.ll +++ b/llvm/test/DebugInfo/varargs.ll @@ -27,6 +27,10 @@ ; CHECK-NOT: DW_TAG ; CHECK: DW_TAG_formal_parameter ; CHECK-NOT: DW_TAG +; CHECK: DW_TAG_variable +; CHECK-NOT: DW_TAG +; CHECK: DW_TAG_variable +; CHECK-NOT: DW_TAG ; CHECK: DW_TAG_unspecified_parameters ; ; Variadic C++ member function. |
