diff options
| author | David Blaikie <dblaikie@gmail.com> | 2015-01-21 22:57:29 +0000 |
|---|---|---|
| committer | David Blaikie <dblaikie@gmail.com> | 2015-01-21 22:57:29 +0000 |
| commit | df706288fba670943e164893e1fa0ccda3e24895 (patch) | |
| tree | 24b3aa2085355e4b8f43177e02bc6fc3e81556e6 /llvm/test/DebugInfo/inline-debug-info-multiret.ll | |
| parent | 07c6bfd50267c551f22191159e11a739723f2d9c (diff) | |
| download | bcm5719-llvm-df706288fba670943e164893e1fa0ccda3e24895.tar.gz bcm5719-llvm-df706288fba670943e164893e1fa0ccda3e24895.zip | |
DebugInfo: Use distinct inlinedAt MDLocations to avoid separate inlined calls being coalesced
When two calls from the same MDLocation are inlined they currently get
treated as one inlined function call (creating difficulty debugging,
duplicate variables, etc).
Clang worked around this by including column information on inline calls
which doesn't address LTO inlining or calls to the same function from
the same line and column (such as through a macro). It also didn't
address ctor and member function calls.
By making the inlinedAt locations distinct, every call site has an
explicitly distinct location that cannot be coalesced with any other
call.
This can produce linearly (2x in the worst case where every call is
inlined and the call instruction has a non-call instruction at the same
location) more debug locations. Any increase beyond that are in cases
where the Clang workaround was insufficient and the new scheme is
creating necessary distinct nodes that were being erroneously coalesced
previously.
After this change to LLVM the incomplete workarounds in Clang. That
should reduce the number of debug locations (in a build without column
info, the default on Darwin, not the default on Linux) by not creating
pseudo-distinct locations for every call to an inline function.
(oh, and I made the inlined-at chain rebuilding iterative instead of
recursive because I was having trouble wrapping my head around it the
way it was - open to discussion on the right design for that function
(including going back to a recursive solution))
llvm-svn: 226736
Diffstat (limited to 'llvm/test/DebugInfo/inline-debug-info-multiret.ll')
| -rw-r--r-- | llvm/test/DebugInfo/inline-debug-info-multiret.ll | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/test/DebugInfo/inline-debug-info-multiret.ll b/llvm/test/DebugInfo/inline-debug-info-multiret.ll index 0115ecd3a8d..71f29ec36bc 100644 --- a/llvm/test/DebugInfo/inline-debug-info-multiret.ll +++ b/llvm/test/DebugInfo/inline-debug-info-multiret.ll @@ -10,7 +10,7 @@ ; CHECK: br label %invoke.cont, !dbg ![[MD]] ; The branch instruction has the source location of line 9 and its inlined location ; has the source location of line 14. -; CHECK: ![[INL:[0-9]+]] = !MDLocation(line: 14, scope: {{.*}}) +; CHECK: ![[INL:[0-9]+]] = distinct !MDLocation(line: 14, scope: {{.*}}) ; CHECK: ![[MD]] = !MDLocation(line: 9, scope: {{.*}}, inlinedAt: ![[INL]]) ; ModuleID = 'test.cpp' |
