diff options
| author | Kuba Mracek <mracek@apple.com> | 2017-08-15 20:29:24 +0000 |
|---|---|---|
| committer | Kuba Mracek <mracek@apple.com> | 2017-08-15 20:29:24 +0000 |
| commit | 17ee427ef35d7521f90f28a7db83fddb4aadd475 (patch) | |
| tree | 0d63ef2fcb684b5fbddf5e45cca3acfded4af8b6 /llvm/test/DebugInfo/PDB | |
| parent | cea6267cc6114bc3ee89e66ede36239841d813c0 (diff) | |
| download | bcm5719-llvm-17ee427ef35d7521f90f28a7db83fddb4aadd475.tar.gz bcm5719-llvm-17ee427ef35d7521f90f28a7db83fddb4aadd475.zip | |
[llvm] Get rid of "%T" expansions
The %T lit expansion expands to a common directory shared between all the tests in the same directory, which is unexpected and unintuitive, and more importantly, it's been a source of subtle race conditions and flaky tests. In https://reviews.llvm.org/D35396, it was agreed that it would be best to simply ban %T and only keep %t, which is unique to each test. When a test needs a temporary directory, it can just create one using mkdir %t.
This patch removes %T in llvm.
Differential Revision: https://reviews.llvm.org/D36495
llvm-svn: 310953
Diffstat (limited to 'llvm/test/DebugInfo/PDB')
| -rw-r--r-- | llvm/test/DebugInfo/PDB/pdbdump-objfilename.yaml | 4 | ||||
| -rw-r--r-- | llvm/test/DebugInfo/PDB/pdbdump-source-names.test | 9 |
2 files changed, 7 insertions, 6 deletions
diff --git a/llvm/test/DebugInfo/PDB/pdbdump-objfilename.yaml b/llvm/test/DebugInfo/PDB/pdbdump-objfilename.yaml index fac9ce9083c..6ddb4775f29 100644 --- a/llvm/test/DebugInfo/PDB/pdbdump-objfilename.yaml +++ b/llvm/test/DebugInfo/PDB/pdbdump-objfilename.yaml @@ -1,5 +1,5 @@ -# RUN: llvm-pdbdump yaml2pdb -pdb=%T/objfilename.pdb %s -# RUN: llvm-pdbdump pdb2yaml -dbi-module-info %T/objfilename.pdb \ +# RUN: llvm-pdbdump yaml2pdb -pdb=%t %s +# RUN: llvm-pdbdump pdb2yaml -dbi-module-info %t \ # RUN: | FileCheck %s # # CHECK: DbiStream: diff --git a/llvm/test/DebugInfo/PDB/pdbdump-source-names.test b/llvm/test/DebugInfo/PDB/pdbdump-source-names.test index f16a2699a15..72816506901 100644 --- a/llvm/test/DebugInfo/PDB/pdbdump-source-names.test +++ b/llvm/test/DebugInfo/PDB/pdbdump-source-names.test @@ -6,11 +6,12 @@ # that differ by one byte, so that at least one of those will only # pass if alignment is implemented correctly. -RUN: llvm-pdbutil yaml2pdb -pdb=%T/source-names-1.pdb %p/Inputs/source-names-1.yaml -RUN: llvm-pdbutil pdb2yaml -module-files %T/source-names-1.pdb \ +RUN: rm -rf %t && mkdir -p %t +RUN: llvm-pdbutil yaml2pdb -pdb=%t/source-names-1.pdb %p/Inputs/source-names-1.yaml +RUN: llvm-pdbutil pdb2yaml -module-files %t/source-names-1.pdb \ RUN: | FileCheck -check-prefix=CHECK1 %s -RUN: llvm-pdbutil yaml2pdb -pdb=%T/source-names-2.pdb %p/Inputs/source-names-2.yaml -RUN: llvm-pdbutil pdb2yaml -module-files %T/source-names-2.pdb \ +RUN: llvm-pdbutil yaml2pdb -pdb=%t/source-names-2.pdb %p/Inputs/source-names-2.yaml +RUN: llvm-pdbutil pdb2yaml -module-files %t/source-names-2.pdb \ RUN: | FileCheck -check-prefix=CHECK2 %s CHECK1: SourceFiles: |
