diff options
| author | Tim Northover <tnorthover@apple.com> | 2016-04-14 17:03:29 +0000 |
|---|---|---|
| committer | Tim Northover <tnorthover@apple.com> | 2016-04-14 17:03:29 +0000 |
| commit | cdf1529c010d28a9102f770727cbdc2f74768de2 (patch) | |
| tree | b4647f11f0499f378904e12cf597d604d34e18e0 /llvm/test/CodeGen | |
| parent | add4a274ba05031f0fb62a9ac430d78e2da6f743 (diff) | |
| download | bcm5719-llvm-cdf1529c010d28a9102f770727cbdc2f74768de2.tar.gz bcm5719-llvm-cdf1529c010d28a9102f770727cbdc2f74768de2.zip | |
AArch64: expand cmpxchg after regalloc at -O0.
FastRegAlloc works only at the basic-block level and spills all live-out
registers. Unfortunately for a stack-based cmpxchg near the spill slots, this
can perpetually clear the exclusive monitor, which means the cmpxchg will never
succeed.
I believe the only way to handle this within LLVM is by expanding the loop
post-regalloc. We don't want this in general because it severely limits the
optimisations that can be done, so we limit this to -O0 compilations.
It's an ugly hack, and about the one good point in the whole mess is that we
can treat all cmpxchg operations in the most naive way possible (seq_cst, no
clrex faff) without affecting correctness.
Should fix PR25526.
llvm-svn: 266339
Diffstat (limited to 'llvm/test/CodeGen')
| -rw-r--r-- | llvm/test/CodeGen/AArch64/cmpxchg-O0.ll | 75 |
1 files changed, 75 insertions, 0 deletions
diff --git a/llvm/test/CodeGen/AArch64/cmpxchg-O0.ll b/llvm/test/CodeGen/AArch64/cmpxchg-O0.ll new file mode 100644 index 00000000000..6c6b022044b --- /dev/null +++ b/llvm/test/CodeGen/AArch64/cmpxchg-O0.ll @@ -0,0 +1,75 @@ +; RUN: llc -mtriple=aarch64-linux-gnu -O0 %s -o - | FileCheck %s + +define { i8, i1 } @test_cmpxchg_8(i8* %addr, i8 %desired, i8 %new) nounwind { +; CHECK-LABEL: test_cmpxchg_8: +; CHECK: [[RETRY:.LBB[0-9]+_[0-9]+]]: +; CHECK: ldaxrb [[OLD:w[0-9]+]], [x0] +; CHECK: cmp [[OLD]], w1, uxtb +; CHECK: b.ne [[DONE:.LBB[0-9]+_[0-9]+]] +; CHECK: stlxrb [[STATUS:w[3-9]]], w2, [x0] +; CHECK: cbnz [[STATUS]], [[RETRY]] +; CHECK: [[DONE]]: +; CHECK: subs {{w[0-9]+}}, [[OLD]], w1 +; CHECK: cset {{w[0-9]+}}, eq + %res = cmpxchg i8* %addr, i8 %desired, i8 %new seq_cst monotonic + ret { i8, i1 } %res +} + +define { i16, i1 } @test_cmpxchg_16(i16* %addr, i16 %desired, i16 %new) nounwind { +; CHECK-LABEL: test_cmpxchg_16: +; CHECK: [[RETRY:.LBB[0-9]+_[0-9]+]]: +; CHECK: ldaxrh [[OLD:w[0-9]+]], [x0] +; CHECK: cmp [[OLD]], w1, uxth +; CHECK: b.ne [[DONE:.LBB[0-9]+_[0-9]+]] +; CHECK: stlxrh [[STATUS:w[3-9]]], w2, [x0] +; CHECK: cbnz [[STATUS]], [[RETRY]] +; CHECK: [[DONE]]: +; CHECK: subs {{w[0-9]+}}, [[OLD]], w1 +; CHECK: cset {{w[0-9]+}}, eq + %res = cmpxchg i16* %addr, i16 %desired, i16 %new seq_cst monotonic + ret { i16, i1 } %res +} + +define { i32, i1 } @test_cmpxchg_32(i32* %addr, i32 %desired, i32 %new) nounwind { +; CHECK-LABEL: test_cmpxchg_32: +; CHECK: [[RETRY:.LBB[0-9]+_[0-9]+]]: +; CHECK: ldaxr [[OLD:w[0-9]+]], [x0] +; CHECK: cmp [[OLD]], w1 +; CHECK: b.ne [[DONE:.LBB[0-9]+_[0-9]+]] +; CHECK: stlxr [[STATUS:w[3-9]]], w2, [x0] +; CHECK: cbnz [[STATUS]], [[RETRY]] +; CHECK: [[DONE]]: +; CHECK: subs {{w[0-9]+}}, [[OLD]], w1 +; CHECK: cset {{w[0-9]+}}, eq + %res = cmpxchg i32* %addr, i32 %desired, i32 %new seq_cst monotonic + ret { i32, i1 } %res +} + +define { i64, i1 } @test_cmpxchg_64(i64* %addr, i64 %desired, i64 %new) nounwind { +; CHECK-LABEL: test_cmpxchg_64: +; CHECK: [[RETRY:.LBB[0-9]+_[0-9]+]]: +; CHECK: ldaxr [[OLD:x[0-9]+]], [x0] +; CHECK: cmp [[OLD]], x1 +; CHECK: b.ne [[DONE:.LBB[0-9]+_[0-9]+]] +; CHECK: stlxr [[STATUS:w[3-9]]], x2, [x0] +; CHECK: cbnz [[STATUS]], [[RETRY]] +; CHECK: [[DONE]]: +; CHECK: subs {{x[0-9]+}}, [[OLD]], x1 +; CHECK: cset {{w[0-9]+}}, eq + %res = cmpxchg i64* %addr, i64 %desired, i64 %new seq_cst monotonic + ret { i64, i1 } %res +} + +define { i128, i1 } @test_cmpxchg_128(i128* %addr, i128 %desired, i128 %new) nounwind { +; CHECK-LABEL: test_cmpxchg_128: +; CHECK: [[RETRY:.LBB[0-9]+_[0-9]+]]: +; CHECK: ldaxp [[OLD_LO:x[0-9]+]], [[OLD_HI:x[0-9]+]], [x0] +; CHECK: cmp [[OLD_LO]], x2 +; CHECK: sbcs xzr, [[OLD_HI]], x3 +; CHECK: b.ne [[DONE:.LBB[0-9]+_[0-9]+]] +; CHECK: stlxp [[STATUS:w[0-9]+]], x4, x5, [x0] +; CHECK: cbnz [[STATUS]], [[RETRY]] +; CHECK: [[DONE]]: + %res = cmpxchg i128* %addr, i128 %desired, i128 %new seq_cst monotonic + ret { i128, i1 } %res +} |

